Re: RFR: 8333303: Issues with DottedVersion class
On Thu, 30 May 2024 20:10:05 GMT, Alexey Semenyuk wrote: > - Get rid of DottedVersion#greedy field. > - Add support to save the unrecognizable remainder of the version string > (required to handle Wix4 version string). > - Implement DottedVersion#equals(). > - add DottedVersion#compareComponents(DottedVersion, DottedVersion) that > compares recognized components of the given DottedVersion instances. > - remove DottedVersion#compareTo(String) > > [Edit](https://bugs.openjdk.org/secure/EditComment!default.jspa?id=5130726=14677610) > [Delete](https://bugs.openjdk.org/secure/DeleteComment!default.jspa?id=5130726=14677610) Looks good. - Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19488#pullrequestreview-2089507390
RFR: 8333303: Issues with DottedVersion class
- Get rid of DottedVersion#greedy field. - Add support to save the unrecognizable remainder of the version string (required to handle Wix4 version string). - Implement DottedVersion#equals(). - add DottedVersion#compareComponents(DottedVersion, DottedVersion) that compares recognized components of the given DottedVersion instances. - remove DottedVersion#compareTo(String) [Edit](https://bugs.openjdk.org/secure/EditComment!default.jspa?id=5130726=14677610) [Delete](https://bugs.openjdk.org/secure/DeleteComment!default.jspa?id=5130726=14677610) - Commit messages: - DottedVersion#compareTo() has been replaced with DottedVersion#compareComponents() - DottedVersion refactored. Old parsing code used "==" to test equality of two BiInteger objects and it didn't work right. When the bug was fixed app version check on Windows platform stopped working. It required a bit of work to get it working right. Changes: https://git.openjdk.org/jdk/pull/19488/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19488=00 Issue: https://bugs.openjdk.org/browse/JDK-803 Stats: 320 lines in 6 files changed: 195 ins; 58 del; 67 mod Patch: https://git.openjdk.org/jdk/pull/19488.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19488/head:pull/19488 PR: https://git.openjdk.org/jdk/pull/19488
Re: RFR: 8333303: Issues with DottedVersion class
On Thu, 30 May 2024 20:10:05 GMT, Alexey Semenyuk wrote: > - Get rid of DottedVersion#greedy field. > - Add support to save the unrecognizable remainder of the version string > (required to handle Wix4 version string). > - Implement DottedVersion#equals(). > - add DottedVersion#compareComponents(DottedVersion, DottedVersion) that > compares recognized components of the given DottedVersion instances. > - remove DottedVersion#compareTo(String) > > [Edit](https://bugs.openjdk.org/secure/EditComment!default.jspa?id=5130726=14677610) > [Delete](https://bugs.openjdk.org/secure/DeleteComment!default.jspa?id=5130726=14677610) @sashamatveev please review - PR Comment: https://git.openjdk.org/jdk/pull/19488#issuecomment-2140794827
