Re: RFR: 8333312: Incorrect since tags on new ClassReader and ConstantPool methods

2024-05-31 Thread Adam Sotona
On Fri, 31 May 2024 13:04:03 GMT, David M. Lloyd  wrote:

> The new method additions ClassReader.readEntryOrNull(int, Class) and 
> ConstantPool.entryByIndex(int, Class) have incorrect since tags; they should 
> be `@since 23`.

Thank you for the fix.

-

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19501#pullrequestreview-2090857569


Re: RFR: 8333312: Incorrect since tags on new ClassReader and ConstantPool methods

2024-05-31 Thread Chen Liang
On Fri, 31 May 2024 13:04:03 GMT, David M. Lloyd  wrote:

> The new method additions ClassReader.readEntryOrNull(int, Class) and 
> ConstantPool.entryByIndex(int, Class) have incorrect since tags; they should 
> be `@since 23`.

Marked as reviewed by liach (Author).

-

PR Review: https://git.openjdk.org/jdk/pull/19501#pullrequestreview-2090804861


RFR: 8333312: Incorrect since tags on new ClassReader and ConstantPool methods

2024-05-31 Thread David M . Lloyd
The new method additions ClassReader.readEntryOrNull(int, Class) and 
ConstantPool.entryByIndex(int, Class) have incorrect since tags; they should be 
`@since 23`.

-

Commit messages:
 - 812: Incorrect since tags on new ClassReader and ConstantPool methods

Changes: https://git.openjdk.org/jdk/pull/19501/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk=19501=00
  Issue: https://bugs.openjdk.org/browse/JDK-812
  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/19501.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19501/head:pull/19501

PR: https://git.openjdk.org/jdk/pull/19501