Re: RFR: 8333854: IllegalAccessError with proxies after JDK-8332457 [v5]
On Thu, 13 Jun 2024 14:11:48 GMT, Chen Liang wrote: >> Please review this patch that fixes a critical issue that breaks some Proxy >> usages. >> >> Since the problematic patch from before cannot be backed out, this patch >> aims to emulate the old behavior before. A diff between before the >> problematic patch and this patch is available at >> https://gist.github.com/7565b2091008f561eb0ada019bc5e517, generated by >> running `git diff 326dbb1b139dd1ec1b8605339b91697cdf49da9a -- >> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java`. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > methodField can be initialized eagerly Thanks for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/19615#issuecomment-2176158264
Re: RFR: 8333854: IllegalAccessError with proxies after JDK-8332457 [v5]
On Thu, 13 Jun 2024 14:11:48 GMT, Chen Liang wrote: >> Please review this patch that fixes a critical issue that breaks some Proxy >> usages. >> >> Since the problematic patch from before cannot be backed out, this patch >> aims to emulate the old behavior before. A diff between before the >> problematic patch and this patch is available at >> https://gist.github.com/7565b2091008f561eb0ada019bc5e517, generated by >> running `git diff 326dbb1b139dd1ec1b8605339b91697cdf49da9a -- >> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java`. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > methodField can be initialized eagerly Marked as reviewed by redestad (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19615#pullrequestreview-2125576655
Re: RFR: 8333854: IllegalAccessError with proxies after JDK-8332457 [v5]
On Thu, 13 Jun 2024 14:11:48 GMT, Chen Liang wrote: >> Please review this patch that fixes a critical issue that breaks some Proxy >> usages. >> >> Since the problematic patch from before cannot be backed out, this patch >> aims to emulate the old behavior before. A diff between before the >> problematic patch and this patch is available at >> https://gist.github.com/7565b2091008f561eb0ada019bc5e517, generated by >> running `git diff 326dbb1b139dd1ec1b8605339b91697cdf49da9a -- >> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java`. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > methodField can be initialized eagerly It is unfortunate that LDC of a CP entry cannot substitute the original complex approach (and the critical cases were not covered by any tests). @liach great work on the restoration of the original approach, while keeping the other improvements Thanks! - Marked as reviewed by asotona (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19615#pullrequestreview-2124720977
Re: RFR: 8333854: IllegalAccessError with proxies after JDK-8332457 [v5]
> Please review this patch that fixes a critical issue that breaks some Proxy > usages. > > Since the problematic patch from before cannot be backed out, this patch aims > to emulate the old behavior before. A diff between before the problematic > patch and this patch is available at > https://gist.github.com/7565b2091008f561eb0ada019bc5e517, generated by > running `git diff 326dbb1b139dd1ec1b8605339b91697cdf49da9a -- > src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java`. Chen Liang has updated the pull request incrementally with one additional commit since the last revision: methodField can be initialized eagerly - Changes: - all: https://git.openjdk.org/jdk/pull/19615/files - new: https://git.openjdk.org/jdk/pull/19615/files/a510b1f4..5668afc1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19615=04 - incr: https://webrevs.openjdk.org/?repo=jdk=19615=03-04 Stats: 13 lines in 1 file changed: 2 ins; 8 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/19615.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19615/head:pull/19615 PR: https://git.openjdk.org/jdk/pull/19615
