Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v3]
On Tue, 18 Jun 2024 07:31:59 GMT, Justin Lu wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add a whitespace before if > > test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java > line 54: > >> 52: import jdk.test.lib.Utils; >> 53: import jdk.test.lib.process.ProcessTools; >> 54: import jdk.test.lib.Platform; > > It would be beneficial to add this issue's bug ID to the Jtreg `@bug` tag. Thanks for the suggestion. The bug id `8334333` has been added. - PR Review Comment: https://git.openjdk.org/jdk/pull/19732#discussion_r1643982602
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v3]
On Tue, 18 Jun 2024 06:31:37 GMT, SendaoYan wrote: >> Hi all, >> Testcase >> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` >> run fails with root user privileged. I think it's necessary to skip this >> testcase when user is root. >> Why run the jtreg test by root user? It's because during rpmbuild process >> for linux distribution of JDK, root user is the default user to build the >> openjdk, also is the default user to run the `make test-tier1`, this PR make >> this testcase more robustness. >> The change has been verified, only change the testcase, no risk. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > add a whitespace before if test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java line 54: > 52: import jdk.test.lib.Utils; > 53: import jdk.test.lib.process.ProcessTools; > 54: import jdk.test.lib.Platform; It would be beneficial to add this issue's bug ID to the Jtreg `@bug` tag. - PR Review Comment: https://git.openjdk.org/jdk/pull/19732#discussion_r1643972916
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v3]
> Hi all, > Testcase > `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` > run fails with root user privileged. I think it's necessary to skip this > testcase when user is root. > Why run the jtreg test by root user? It's because during rpmbuild process for > linux distribution of JDK, root user is the default user to build the > openjdk, also is the default user to run the `make test-tier1`, this PR make > this testcase more robustness. > The change has been verified, only change the testcase, no risk. SendaoYan has updated the pull request incrementally with one additional commit since the last revision: add a whitespace before if - Changes: - all: https://git.openjdk.org/jdk/pull/19732/files - new: https://git.openjdk.org/jdk/pull/19732/files/9b8a0bcb..90d3b335 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19732&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19732&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/19732.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19732/head:pull/19732 PR: https://git.openjdk.org/jdk/pull/19732