Re: RFR: 8334437: De-duplicate ProxyMethod list creation

2024-06-26 Thread Claes Redestad 
On Tue, 18 Jun 2024 07:41:26 GMT, Claes Redestad  wrote:

> Simple refactoring to extract identical, simple lambda expressions. Improve 
> code clarity and reduce classes generated.

Thanks!

-

PR Comment: https://git.openjdk.org/jdk/pull/19760#issuecomment-2191894639

Re: RFR: 8334437: De-duplicate ProxyMethod list creation

2024-06-26 Thread Chen Liang 
On Tue, 18 Jun 2024 07:41:26 GMT, Claes Redestad  wrote:

> Simple refactoring to extract identical, simple lambda expressions. Improve 
> code clarity and reduce classes generated.

Marked as reviewed by liach (Committer).

-

PR Review: https://git.openjdk.org/jdk/pull/19760#pullrequestreview-2141860506

Re: RFR: 8334437: De-duplicate ProxyMethod list creation

2024-06-26 Thread Adam Sotona 
On Tue, 18 Jun 2024 07:41:26 GMT, Claes Redestad  wrote:

> Simple refactoring to extract identical, simple lambda expressions. Improve 
> code clarity and reduce classes generated.

Looks good to me.

-

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19760#pullrequestreview-2141591212

Re: RFR: 8334437: De-duplicate ProxyMethod list creation

2024-06-26 Thread Claes Redestad 
On Tue, 18 Jun 2024 07:41:26 GMT, Claes Redestad  wrote:

> Simple refactoring to extract identical, simple lambda expressions. Improve 
> code clarity and reduce classes generated.

Friendly reminder that this trivial improvement needs a reviewer.

-

PR Comment: https://git.openjdk.org/jdk/pull/19760#issuecomment-2191352440

RFR: 8334437: De-duplicate ProxyMethod list creation

2024-06-18 Thread Claes Redestad 
Simple refactoring to extract identical, simple lambda expressions. Improve 
code clarity and reduce classes generated.

-

Commit messages:
 - Simplify
 - Refactor ProxyMethod list creation

Changes: https://git.openjdk.org/jdk/pull/19760/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk=19760=00
  Issue: https://bugs.openjdk.org/browse/JDK-8334437
  Stats: 10 lines in 1 file changed: 4 ins; 4 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/19760.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19760/head:pull/19760

PR: https://git.openjdk.org/jdk/pull/19760