Re: RFR: 8334653: ISO 4217 Amendment 177 Update [v3]

2024-07-10 Thread Steven Loomis
On Fri, 21 Jun 2024 01:58:05 GMT, Naoto Sato  wrote:

> Out of curiosity, what's the rationale behind the currency name change from 
> "Zimbabwe Dollar" (ISO 4217 definition) to "Zimbabwean Dollar"?

I'm not sure.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/19813#discussion_r1673107271


Re: RFR: 8334653: ISO 4217 Amendment 177 Update [v3]

2024-06-21 Thread Naoto Sato
On Thu, 20 Jun 2024 20:12:39 GMT, Justin Lu  wrote:

>> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
>> 
>> Specifically, the introduction of the new currency, Zimbabwe Gold.
>
> Justin Lu has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   reflect review: change txt name

Marked as reviewed by naoto (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/19813#pullrequestreview-2132659325


Re: RFR: 8334653: ISO 4217 Amendment 177 Update [v3]

2024-06-20 Thread Naoto Sato
On Thu, 20 Jun 2024 20:30:36 GMT, Steven Loomis  wrote:

> CLDR is aware of this change but hasn't added it yet. We're mid cycle so it 
> won't be much more than metadata this round due to timing. 
> https://unicode-org.atlassian.net/issues/CLDR-17751 if you want to track.

Out of curiosity, what's the rationale behind the currency name change from 
"Zimbabwe Dollar" (ISO 4217 definition) to "Zimbabwean Dollar"?

-

PR Review Comment: https://git.openjdk.org/jdk/pull/19813#discussion_r1648324116


Re: RFR: 8334653: ISO 4217 Amendment 177 Update [v3]

2024-06-20 Thread Steven Loomis
On Thu, 20 Jun 2024 19:47:56 GMT, Naoto Sato  wrote:

>> I see your point. CLDR takes precedence over ISO4217 regarding currencies 
>> here?
>
> That is more consistent IMO

CLDR is aware of this change but hasn't added it yet. We're mid cycle so it 
won't be much more than metadata this round due to timing.  
https://unicode-org.atlassian.net/issues/CLDR-17751 if you want to track.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/19813#discussion_r1648094193


Re: RFR: 8334653: ISO 4217 Amendment 177 Update [v3]

2024-06-20 Thread Justin Lu
> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
> 
> Specifically, the introduction of the new currency, Zimbabwe Gold.

Justin Lu has updated the pull request incrementally with one additional commit 
since the last revision:

  reflect review: change txt name

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/19813/files
  - new: https://git.openjdk.org/jdk/pull/19813/files/761d8efc..58c09005

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19813&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19813&range=01-02

  Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/19813.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19813/head:pull/19813

PR: https://git.openjdk.org/jdk/pull/19813