Re: RFR: 8334726: Remove accidentally exposed individual methods from Class-File API

2024-06-21 Thread Adam Sotona
On Fri, 21 Jun 2024 14:38:44 GMT, Chen Liang  wrote:

> In preparation of Class-File API exiting review, we are housekeeping our API 
> surface. These 3 method removals are the most obvious and simple ones.
> 
> This is separated from more throughout and (possibly controversial) changes 
> for the future, to make reviews (both code and CSR) easier.

Looks good to me, thanks.

-

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19832#pullrequestreview-2132887472


RFR: 8334726: Remove accidentally exposed individual methods from Class-File API

2024-06-21 Thread Chen Liang
In preparation of Class-File API exiting review, we are housekeeping our API 
surface. These 3 method removals are the most obvious and simple ones.

This is separated from more throughout and (possibly controversial) changes for 
the future, to make reviews (both code and CSR) easier.

-

Commit messages:
 - 8334726: Remove accidentally exposed individual methods from Class-File API

Changes: https://git.openjdk.org/jdk/pull/19832/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk=19832=00
  Issue: https://bugs.openjdk.org/browse/JDK-8334726
  Stats: 37 lines in 7 files changed: 0 ins; 30 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/19832.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19832/head:pull/19832

PR: https://git.openjdk.org/jdk/pull/19832