Re: RFR: 8334734: Remove specialized readXxxEntry methods from ClassReader

2024-06-24 Thread Adam Sotona 
On Fri, 21 Jun 2024 15:52:44 GMT, Chen Liang  wrote:

> `ClassReader.readXxxEntry` were added before we had generic, type-aware 
> `readEntry` and `readEntryOrNull` APIs (#19330). We should remove these 
> specialized versions in favor of the generic version to reduce API bloating.

Looks good to me, thanks.

-

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19833#pullrequestreview-2134895664

RFR: 8334734: Remove specialized readXxxEntry methods from ClassReader

2024-06-21 Thread Chen Liang 
`ClassReader.readXxxEntry` were added before we had generic, type-aware 
`readEntry` and `readEntryOrNull` APIs (#19330). We should remove these 
specialized versions in favor of the generic version to reduce API bloating.

-

Commit messages:
 - Copyright years
 - 8334734: Remove specialized readXxxEntry methods from ClassReader

Changes: https://git.openjdk.org/jdk/pull/19833/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk=19833=00
  Issue: https://bugs.openjdk.org/browse/JDK-8334734
  Stats: 169 lines in 9 files changed: 1 ins; 111 del; 57 mod
  Patch: https://git.openjdk.org/jdk/pull/19833.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19833/head:pull/19833

PR: https://git.openjdk.org/jdk/pull/19833