Re: RFR: 8335110: Fix instruction name and API spec inconsistencies in CodeBuilder [v2]
On Tue, 25 Jun 2024 21:22:34 GMT, Chen Liang wrote: >> This is a collection of fixes and improvements to CodeBuilder, plus 2 >> renames. >> >> Fixes include: >> 1. `CodeBuilder::receiverSlot` typo >> 2. `CodeAttribute::labelToBci` update spec >> 3. `CodeBuilder::exceptionCatch` implementation >> 4. `CodeBuilder::if_nonnull`/`if_null` -> `ifnonnull`/`ifnull` >> 5. Docs for what instructions factories emit, and to explain why some >> factories have name mismatch; also a section in summary. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > Patch in csr but forgot to upload Looks good to me, thank you. - Marked as reviewed by asotona (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19889#pullrequestreview-2141230227
Re: RFR: 8335110: Fix instruction name and API spec inconsistencies in CodeBuilder [v2]
> This is a collection of fixes and improvements to CodeBuilder, plus 2 renames. > > Fixes include: > 1. `CodeBuilder::receiverSlot` typo > 2. `CodeAttribute::labelToBci` update spec > 3. `CodeBuilder::exceptionCatch` implementation > 4. `CodeBuilder::if_nonnull`/`if_null` -> `ifnonnull`/`ifnull` > 5. Docs for what instructions factories emit, and to explain why some > factories have name mismatch; also a section in summary. Chen Liang has updated the pull request incrementally with one additional commit since the last revision: Patch in csr but forgot to upload - Changes: - all: https://git.openjdk.org/jdk/pull/19889/files - new: https://git.openjdk.org/jdk/pull/19889/files/013a5cf2..8fe07e1c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19889&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19889&range=00-01 Stats: 15 lines in 1 file changed: 0 ins; 1 del; 14 mod Patch: https://git.openjdk.org/jdk/pull/19889.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19889/head:pull/19889 PR: https://git.openjdk.org/jdk/pull/19889
RFR: 8335110: Fix instruction name and API spec inconsistencies in CodeBuilder
This is a collection of fixes and improvements to CodeBuilder, plus 2 renames. Fixes include: 1. `CodeBuilder::receiverSlot` typo 2. `CodeAttribute::labelToBci` update spec 3. `CodeBuilder::exceptionCatch` implementation 4. `CodeBuilder::if_nonnull`/`if_null` -> `ifnonnull`/`ifnull` 5. Docs for what instructions factories emit, and to explain why some factories have name mismatch; also a section in summary. - Commit messages: - Describe extra types of instructions that can be generated - Minor polishing to CodeBuilder Changes: https://git.openjdk.org/jdk/pull/19889/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19889&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335110 Stats: 123 lines in 6 files changed: 106 ins; 1 del; 16 mod Patch: https://git.openjdk.org/jdk/pull/19889.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19889/head:pull/19889 PR: https://git.openjdk.org/jdk/pull/19889
