Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v6]

2024-01-26 Thread Jim Laskey 
On Fri, 19 Jan 2024 17:39:57 GMT, Raffaello Giulietti  
wrote:

>> Jim Laskey has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Update copyright year of test
>
> test/jdk/java/lang/String/TranslateEscapes.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2019, 2024 Oracle and/or its affiliates. All rights 
>> reserved.
> 
> Sorry for this late note.
> Seems like each copyright year must be followed by a comma `,`, otherwise 
> validate-source fails. See, for example, my own oversight 
> [here](https://github.com/openjdk/jdk/pull/17490/files).

Changed

-

PR Review Comment: https://git.openjdk.org/jdk/pull/17491#discussion_r1467631294

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v6]

2024-01-19 Thread Raffaello Giulietti 
On Fri, 19 Jan 2024 14:14:26 GMT, Jim Laskey  wrote:

>> Currently String::translateEscapes does not support unicode escapes, 
>> reported as a IllegalArgumentException("Invalid escape sequence: ..."). 
>> String::translateEscapes should translate unicode escape sequences to 
>> provide full coverage,
>
> Jim Laskey has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update copyright year of test

test/jdk/java/lang/String/TranslateEscapes.java line 2:

> 1: /*
> 2:  * Copyright (c) 2019, 2024 Oracle and/or its affiliates. All rights 
> reserved.

Sorry for this late note.
Seems like each copyright year must be followed by a comma `,`, otherwise 
validate-source fails. See, for example, my own oversight 
[here](https://github.com/openjdk/jdk/pull/17490/files).

-

PR Review Comment: https://git.openjdk.org/jdk/pull/17491#discussion_r1459422630

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v6]

2024-01-19 Thread Jim Laskey 
> Currently String::translateEscapes does not support unicode escapes, reported 
> as a IllegalArgumentException("Invalid escape sequence: ..."). 
> String::translateEscapes should translate unicode escape sequences to provide 
> full coverage,

Jim Laskey has updated the pull request incrementally with one additional 
commit since the last revision:

  Update copyright year of test

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/17491/files
  - new: https://git.openjdk.org/jdk/pull/17491/files/14b2f6c2..79312823

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=17491=05
 - incr: https://webrevs.openjdk.org/?repo=jdk=17491=04-05

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17491.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17491/head:pull/17491

PR: https://git.openjdk.org/jdk/pull/17491

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v6]

2024-01-19 Thread Raffaello Giulietti 
On Fri, 19 Jan 2024 14:10:48 GMT, Jim Laskey  wrote:

>> Currently String::translateEscapes does not support unicode escapes, 
>> reported as a IllegalArgumentException("Invalid escape sequence: ..."). 
>> String::translateEscapes should translate unicode escape sequences to 
>> provide full coverage,
>
> Jim Laskey has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update copyright year of test

Looks good

-

Marked as reviewed by rgiulietti (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17491#pullrequestreview-1832778162