Re: RFR: JDK-8289106: Add model of class file versions to core reflection [v2]
On Mon, 11 Jul 2022 20:31:04 GMT, Mandy Chung wrote: > This `ClassFileFormatVersion` API is a good proposal. It can also reference > `java.class.version` system property to map to the latest class file format > version. Good idea Mandy; I'll add that reference and start working on the implementation of the partially implemented method. Thanks. - PR: https://git.openjdk.org/jdk/pull/9299
Re: RFR: JDK-8289106: Add model of class file versions to core reflection [v2]
On Wed, 29 Jun 2022 21:32:29 GMT, Joe Darcy wrote: >> JDK-8289106: Add model of class file versions to core reflection > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 10 additional commits since > the last revision: > > - Add method to map from major class file version. > - Merge branch 'master' into JDK-8289106 > - Update phrasing. > - Augment and correct docs. > - Correct major versions; RELEASE_0 and RELEASE_1 are both 45. > - Make major method public. > - Add AccessFlag.locations(ClassFileFormatVersion) > - Add ClassFileFormatVersion <-> Runtime.Version conversions. > - Merge branch 'master' into JDK-8289106 > - JDK-8289106: Add model of class file versions to core reflection This `ClassFileFormatVersion` API is a good proposal. It can also reference `java.class.version` system property to map to the latest class file format version. - PR: https://git.openjdk.org/jdk/pull/9299
Re: RFR: JDK-8289106: Add model of class file versions to core reflection [v2]
On Wed, 29 Jun 2022 21:32:29 GMT, Joe Darcy wrote: >> JDK-8289106: Add model of class file versions to core reflection > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 10 additional commits since > the last revision: > > - Add method to map from major class file version. > - Merge branch 'master' into JDK-8289106 > - Update phrasing. > - Augment and correct docs. > - Correct major versions; RELEASE_0 and RELEASE_1 are both 45. > - Make major method public. > - Add AccessFlag.locations(ClassFileFormatVersion) > - Add ClassFileFormatVersion <-> Runtime.Version conversions. > - Merge branch 'master' into JDK-8289106 > - JDK-8289106: Add model of class file versions to core reflection I like the proposed concept and Classfile Processing API is definitely one of the potential consumers. - PR: https://git.openjdk.org/jdk/pull/9299
Re: RFR: JDK-8289106: Add model of class file versions to core reflection [v2]
> JDK-8289106: Add model of class file versions to core reflection Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: - Add method to map from major class file version. - Merge branch 'master' into JDK-8289106 - Update phrasing. - Augment and correct docs. - Correct major versions; RELEASE_0 and RELEASE_1 are both 45. - Make major method public. - Add AccessFlag.locations(ClassFileFormatVersion) - Add ClassFileFormatVersion <-> Runtime.Version conversions. - Merge branch 'master' into JDK-8289106 - JDK-8289106: Add model of class file versions to core reflection - Changes: - all: https://git.openjdk.org/jdk/pull/9299/files - new: https://git.openjdk.org/jdk/pull/9299/files/cf144d66..27a8e194 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=9299=01 - incr: https://webrevs.openjdk.org/?repo=jdk=9299=00-01 Stats: 6369 lines in 171 files changed: 3641 ins; 1373 del; 1355 mod Patch: https://git.openjdk.org/jdk/pull/9299.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9299/head:pull/9299 PR: https://git.openjdk.org/jdk/pull/9299
