Re: RFR: JDK-8297299 SequenceInputStream should not use Vector [v6]

2022-11-21 Thread Jaikiran Pai 
On Mon, 21 Nov 2022 17:43:23 GMT, Markus KARG  wrote:

>> There is no need to use a temporary Vector within the constructor of 
>> SynchronizedInputStream, as more efficient (non-synchronized) alternative 
>> code (like List.of) will do the same in possibly less time. While the 
>> optimization is not dramatic, it still makes sense to replace Vector unless 
>> synchronization is really needed.
>
> Markus KARG has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   private member variables

Thank you Markus for these changes. The latest state in `8d298318` looks good 
to me. I'll run some tests today before sponsoring this.

-

Marked as reviewed by jpai (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11249

Re: RFR: JDK-8297299 SequenceInputStream should not use Vector [v6]

2022-11-21 Thread Alan Bateman 
On Mon, 21 Nov 2022 17:39:24 GMT, Markus KARG  wrote:

>> There is no need to use a temporary Vector within the constructor of 
>> SynchronizedInputStream, as more efficient (non-synchronized) alternative 
>> code (like List.of) will do the same in possibly less time. While the 
>> optimization is not dramatic, it still makes sense to replace Vector unless 
>> synchronization is really needed.
>
> Markus KARG has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   private member variables

Marked as reviewed by alanb (Reviewer).

-

PR: https://git.openjdk.org/jdk/pull/11249

Re: RFR: JDK-8297299 SequenceInputStream should not use Vector [v6]

2022-11-21 Thread Markus KARG 
> There is no need to use a temporary Vector within the constructor of 
> SynchronizedInputStream, as more efficient (non-synchronized) alternative 
> code (like List.of) will do the same in possibly less time. While the 
> optimization is not dramatic, it still makes sense to replace Vector unless 
> synchronization is really needed.

Markus KARG has updated the pull request incrementally with one additional 
commit since the last revision:

  private member variables

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/11249/files
  - new: https://git.openjdk.org/jdk/pull/11249/files/2e957354..8d298318

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=11249=05
 - incr: https://webrevs.openjdk.org/?repo=jdk=11249=04-05

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/11249.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11249/head:pull/11249

PR: https://git.openjdk.org/jdk/pull/11249