Re: RFR: JDK-8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [[i4](struct)] but found [[I4](struct)]

2023-07-25 Thread Per Minborg
On Tue, 25 Jul 2023 10:57:48 GMT, Matthias Baesken  wrote:

> > I put this patch into our internal test queue to see how it works on AIX.
> 
> AIX tests are fine too.

Great! Thanks for testing this!

-

PR Comment: https://git.openjdk.org/jdk/pull/14994#issuecomment-1649617257


Re: RFR: JDK-8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [[i4](struct)] but found [[I4](struct)]

2023-07-25 Thread Matthias Baesken
On Mon, 24 Jul 2023 13:55:18 GMT, Matthias Baesken  wrote:

>  I put this patch into our internal test queue to see how it works on AIX.

AIX tests are fine too.

-

PR Comment: https://git.openjdk.org/jdk/pull/14994#issuecomment-1649612399


Re: RFR: JDK-8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [[i4](struct)] but found [[I4](struct)]

2023-07-24 Thread Matthias Baesken
On Mon, 24 Jul 2023 09:51:33 GMT, Per Minborg  wrote:

> This PR suggests making a test independent of the underlying platform byte 
> ordering and to test both ordering variants rather than just one.

Hi Per-Ake, I put this patch into our internal test queue to see how it works 
on AIX.

-

PR Comment: https://git.openjdk.org/jdk/pull/14994#issuecomment-1647966305


Re: RFR: JDK-8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [[i4](struct)] but found [[I4](struct)]

2023-07-24 Thread Jorn Vernee
On Mon, 24 Jul 2023 09:51:33 GMT, Per Minborg  wrote:

> This PR suggests making a test independent of the underlying platform byte 
> ordering and to test both ordering variants rather than just one.

Marked as reviewed by jvernee (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/14994#pullrequestreview-1543507248


RFR: JDK-8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [[i4](struct)] but found [[I4](struct)]

2023-07-24 Thread Per Minborg
This PR suggests making a test independent of the underlying platform byte 
ordering and to test both ordering variants rather than just one.

-

Commit messages:
 - Make test independent of platform byte ordering

Changes: https://git.openjdk.org/jdk/pull/14994/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk=14994=00
  Issue: https://bugs.openjdk.org/browse/JDK-8311822
  Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/14994.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14994/head:pull/14994

PR: https://git.openjdk.org/jdk/pull/14994