Re: RFR: 8275338: Add JFR events for notable serialization situations [v14]

2024-01-15 Thread Raffaello Giulietti
On Wed, 10 Jan 2024 18:56:45 GMT, Raffaello Giulietti  
wrote:

>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Small space optimization.

Anybody from security wants to chime in?

-

PR Comment: https://git.openjdk.org/jdk/pull/17129#issuecomment-1891808292


Re: RFR: 8275338: Add JFR events for notable serialization situations [v14]

2024-01-12 Thread Roger Riggs
On Wed, 10 Jan 2024 18:56:45 GMT, Raffaello Giulietti  
wrote:

>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Small space optimization.

Thanks for the updates.  LGTM

-

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17129#pullrequestreview-1818884173


Re: RFR: 8275338: Add JFR events for notable serialization situations [v14]

2024-01-10 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR.

Raffaello Giulietti has updated the pull request incrementally with one 
additional commit since the last revision:

  Small space optimization.

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/17129/files
  - new: https://git.openjdk.org/jdk/pull/17129/files/ff1b7068..b76285d9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=17129=13
 - incr: https://webrevs.openjdk.org/?repo=jdk=17129=12-13

  Stats: 10 lines in 2 files changed: 5 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/17129.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17129/head:pull/17129

PR: https://git.openjdk.org/jdk/pull/17129