Re: RFR: 8290504: Close streams returned by ModuleReader::list [v4]
On Thu, 21 Jul 2022 13:23:43 GMT, Ryan Ernst wrote: >> This commit ensures streams returned by ModuleReader::list are closed. > > Ryan Ernst has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into try_files/module_reader_uses > - fix caller sensitive test uses > - silly spaces > - Merge branch 'master' into try_files/module_reader_uses > - revert CallerSensitiveAccess change > - 8290504: Close streams returned by ModuleReader::list > >This commit ensures streams returned by ModuleReader::list are closed. LGTM. - Marked as reviewed by chegar (Reviewer). PR: https://git.openjdk.org/jdk/pull/9557
Re: RFR: 8290504: Close streams returned by ModuleReader::list [v4]
> This commit ensures streams returned by ModuleReader::list are closed. Ryan Ernst has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge branch 'master' into try_files/module_reader_uses - fix caller sensitive test uses - silly spaces - Merge branch 'master' into try_files/module_reader_uses - revert CallerSensitiveAccess change - 8290504: Close streams returned by ModuleReader::list This commit ensures streams returned by ModuleReader::list are closed. - Changes: https://git.openjdk.org/jdk/pull/9557/files Webrev: https://webrevs.openjdk.org/?repo=jdk=9557=03 Stats: 20 lines in 4 files changed: 11 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/9557.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9557/head:pull/9557 PR: https://git.openjdk.org/jdk/pull/9557
Re: RFR: 8290504: Close streams returned by ModuleReader::list [v4]
On Thu, 21 Jul 2022 06:53:53 GMT, Chris Hegarty wrote: >> Done in >> [4a94c64](https://github.com/openjdk/jdk/pull/9557/commits/4a94c645fe1e37abc694f81fd8e401c5dc367d68) > > @rjernst it seems that the _revert_ part of the above has been done, but not > the "have the callerSensitiveMethods DataProvider close the returned stream". Sorry I misunderstood. Fixed now in [3080378](https://github.com/openjdk/jdk/pull/9557/commits/30803780ca0bd1bcf03b99947ebf8cd4b42e6070). - PR: https://git.openjdk.org/jdk/pull/9557
