Re: RFR: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) [v2]
On Thu, 17 Nov 2022 22:06:47 GMT, Brent Christian wrote: > > Is a CSR needed here? > I will check A CSR is not needed. - PR: https://git.openjdk.org/jdk/pull/11218
Re: RFR: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) [v2]
On Thu, 17 Nov 2022 20:32:15 GMT, Brent Christian wrote: >> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the >> shutdown sequence, noting that calling Runtime.halt() skips the shutdown >> sequence and immediately terminates the VM. Thus, "threads' current methods >> do not complete normally or abruptly; no finally clause of any method is >> executed". >> >> One ramification of this is that resources within try-with-resource blocks >> will not be released. It would be good to state this explicitly. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > It's "try-with-resources" (Updated the wording, per comment in the bug report) - PR: https://git.openjdk.org/jdk/pull/11218
Re: RFR: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) [v2]
On Thu, 17 Nov 2022 20:36:01 GMT, Brian Burkhalter wrote: > Is a CSR needed here? I will check, though the thought is that these are non-normative clarifications to the normative changes made by [8290036](https://bugs.openjdk.org/browse/JDK-8290036). - PR: https://git.openjdk.org/jdk/pull/11218
Re: RFR: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) [v2]
On Thu, 17 Nov 2022 20:32:15 GMT, Brent Christian wrote: >> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the >> shutdown sequence, noting that calling Runtime.halt() skips the shutdown >> sequence and immediately terminates the VM. Thus, "threads' current methods >> do not complete normally or abruptly; no finally clause of any method is >> executed". >> >> One ramification of this is that resources within try-with-resource blocks >> will not be released. It would be good to state this explicitly. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > It's "try-with-resources" Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11218
Re: RFR: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) [v2]
On Thu, 17 Nov 2022 20:32:15 GMT, Brent Christian wrote: >> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the >> shutdown sequence, noting that calling Runtime.halt() skips the shutdown >> sequence and immediately terminates the VM. Thus, "threads' current methods >> do not complete normally or abruptly; no finally clause of any method is >> executed". >> >> One ramification of this is that resources within try-with-resource blocks >> will not be released. It would be good to state this explicitly. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > It's "try-with-resources" Looks good now. Is a CSR needed here? - Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.org/jdk/pull/11218
Re: RFR: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) [v2]
> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the > shutdown sequence, noting that calling Runtime.halt() skips the shutdown > sequence and immediately terminates the VM. Thus, "threads' current methods > do not complete normally or abruptly; no finally clause of any method is > executed". > > One ramification of this is that resources within try-with-resource blocks > will not be released. It would be good to state this explicitly. Brent Christian has updated the pull request incrementally with one additional commit since the last revision: It's "try-with-resources" - Changes: - all: https://git.openjdk.org/jdk/pull/11218/files - new: https://git.openjdk.org/jdk/pull/11218/files/de091d83..9983fa68 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=11218=01 - incr: https://webrevs.openjdk.org/?repo=jdk=11218=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/11218.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11218/head:pull/11218 PR: https://git.openjdk.org/jdk/pull/11218
