Re: RFR: 8296431 - PushbackInputStream should override transferTo [v4]

2022-11-11 Thread Markus KARG 
On Fri, 11 Nov 2022 12:32:10 GMT, Alan Bateman  wrote:

> I don't have any other comments. @bplb told me that he would sponsor this for 
> you.

Thanks, but I need a successful review logged first. :-)

-

PR: https://git.openjdk.org/jdk/pull/10999

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v4]

2022-11-11 Thread Alan Bateman 
On Mon, 7 Nov 2022 14:24:18 GMT, Markus KARG  wrote:

> @AlanBateman I fixed what you asked for. Kindly requesting review. :-)

I don't have any other comments. @bplb told me that he would sponsor this for 
you.

-

PR: https://git.openjdk.org/jdk/pull/10999

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v4]

2022-11-08 Thread Markus KARG 
On Mon, 7 Nov 2022 17:29:15 GMT, Brian Burkhalter  wrote:

>> Markus KARG has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   fixed typo
>
> test/jdk/java/io/PushbackInputStream/TransferTo.java line 24:
> 
>> 22:  */
>> 23: 
>> 24: import java.io.BufferedInputStream;
> 
> It looks as if there are several unnecessary imports in this test. Please 
> pare them down to those classes actually used.

Thanks. I have removed the unused imports.

-

PR: https://git.openjdk.org/jdk/pull/10999

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v4]

2022-11-07 Thread Brian Burkhalter 
On Sat, 5 Nov 2022 18:29:47 GMT, Markus KARG  wrote:

>> This PR implements JDK-8296431
>
> Markus KARG has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fixed typo

test/jdk/java/io/PushbackInputStream/TransferTo.java line 24:

> 22:  */
> 23: 
> 24: import java.io.BufferedInputStream;

It looks as if there are several unnecessary imports in this test. Please pare 
them down to those classes actually used.

-

PR: https://git.openjdk.org/jdk/pull/10999

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v4]

2022-11-07 Thread Markus KARG 
On Sat, 5 Nov 2022 18:29:47 GMT, Markus KARG  wrote:

>> This PR implements JDK-8296431
>
> Markus KARG has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fixed typo

@AlanBateman I fixed what you asked for. Kindly requesting review. :-)

-

PR: https://git.openjdk.org/jdk/pull/10999

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v4]

2022-11-05 Thread Markus KARG 
> This PR implements JDK-8296431

Markus KARG has updated the pull request incrementally with one additional 
commit since the last revision:

  fixed typo

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/10999/files
  - new: https://git.openjdk.org/jdk/pull/10999/files/f7ee1c7a..b6f4d8cb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10999&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10999&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/10999.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10999/head:pull/10999

PR: https://git.openjdk.org/jdk/pull/10999