Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints() [v4]
On Thu, 1 Dec 2022 08:14:07 GMT, Sergey Tsypanov wrote: >> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` >> which in turn specifies the same exception thrown under the same conditions >> and the implementation does exactly the same checks. This means we can >> remove the check from `String.offsetByCodePoints()` and rely on the one of >> `Character.offsetByCodePoints()`. > > Sergey Tsypanov has updated the pull request incrementally with two > additional commits since the last revision: > > - 8297561: Minor clean-up > - 8297561: Fix copyright year Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11350
Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints() [v4]
On Thu, 1 Dec 2022 08:14:07 GMT, Sergey Tsypanov wrote: >> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` >> which in turn specifies the same exception thrown under the same conditions >> and the implementation does exactly the same checks. This means we can >> remove the check from `String.offsetByCodePoints()` and rely on the one of >> `Character.offsetByCodePoints()`. > > Sergey Tsypanov has updated the pull request incrementally with two > additional commits since the last revision: > > - 8297561: Minor clean-up > - 8297561: Fix copyright year Marked as reviewed by redestad (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11350
Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints() [v4]
> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` > which in turn specifies the same exception thrown under the same conditions > and the implementation does exactly the same checks. This means we can remove > the check from `String.offsetByCodePoints()` and rely on the one of > `Character.offsetByCodePoints()`. Sergey Tsypanov has updated the pull request incrementally with two additional commits since the last revision: - 8297561: Minor clean-up - 8297561: Fix copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/11350/files - new: https://git.openjdk.org/jdk/pull/11350/files/2d7b178c..7fea8d51 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=11350=03 - incr: https://webrevs.openjdk.org/?repo=jdk=11350=02-03 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/11350.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11350/head:pull/11350 PR: https://git.openjdk.org/jdk/pull/11350
