Re: RFR: 8303472: Display name for region TR [v2]
On Wed, 1 Mar 2023 23:45:47 GMT, Justin Lu wrote: >> This PR changes the English name for the region `TR`, from `Turkey` to >> `Türkiye`. Although this change is included in the upcoming CLDR v43, it >> should be applied as a spot change so that it can be back-ported properly >> (As it is a common English region name). >> >> >> >> This change targets both the CLDR and COMPAT data. > > Justin Lu has updated the pull request incrementally with two additional > commits since the last revision: > > - Supply test with changes, use unicode escapes to be consistent > - copyright year Marked as reviewed by srl...@github.com (no known OpenJDK username). - PR: https://git.openjdk.org/jdk/pull/12816
Re: RFR: 8303472: Display name for region TR [v2]
On Wed, 1 Mar 2023 23:45:47 GMT, Justin Lu wrote: >> This PR changes the English name for the region `TR`, from `Turkey` to >> `Türkiye`. Although this change is included in the upcoming CLDR v43, it >> should be applied as a spot change so that it can be back-ported properly >> (As it is a common English region name). >> >> >> >> This change targets both the CLDR and COMPAT data. > > Justin Lu has updated the pull request incrementally with two additional > commits since the last revision: > > - Supply test with changes, use unicode escapes to be consistent > - copyright year Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12816
Re: RFR: 8303472: Display name for region TR [v2]
On Wed, 1 Mar 2023 22:52:09 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Supply test with changes, use unicode escapes to be consistent >> - copyright year > > src/java.base/share/classes/sun/util/resources/LocaleNames.properties line > 1097: > >> 1095: TN=Tunisia >> 1096: TO=Tonga >> 1097: TR=Türkiye > > I believe this is fine, but please confirm that this ends up correct u-umlaut > when you get the text. It is somewhat a rare case where ISO-8859-1 has the > character and the byte sequence differs between ISO-8859-1 and UTF-8. Thanks for pointing that out, I switched it to just be a unicode escaped ü, as that would be more consistent with the rest of the file. I also added the changes to the test files like you suggested. - PR: https://git.openjdk.org/jdk/pull/12816
Re: RFR: 8303472: Display name for region TR [v2]
> This PR changes the English name for the region `TR`, from `Turkey` to > `Türkiye`. Although this change is included in the upcoming CLDR v43, it > should be applied as a spot change so that it can be back-ported properly (As > it is a common English region name). > > > > This change targets both the CLDR and COMPAT data. Justin Lu has updated the pull request incrementally with two additional commits since the last revision: - Supply test with changes, use unicode escapes to be consistent - copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/12816/files - new: https://git.openjdk.org/jdk/pull/12816/files/c996ca27..5bedc6a0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=12816=01 - incr: https://webrevs.openjdk.org/?repo=jdk=12816=00-01 Stats: 9 lines in 4 files changed: 6 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/12816.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12816/head:pull/12816 PR: https://git.openjdk.org/jdk/pull/12816
