Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v6]
On Wed, 31 May 2023 14:32:25 GMT, Roger Riggs wrote: >> Refactor the Platform class in jdk.jpackage to use the internal >> OperatingSystem, Architecture, and Version classes. >> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace >> comparisons in the Platform class. >> The checks of the os.version are replaced but may not be needed if OpenJDK >> no longer supports them. >> >> It is recommended to remove os version checks that apply only to Mac >> versions before 10.15. >> Mac OS X 10.15 is the oldest version supported. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing import of OSVersion Marked as reviewed by asemenyuk (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13586#pullrequestreview-1453868736
Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v6]
On Wed, 31 May 2023 14:32:25 GMT, Roger Riggs wrote: >> Refactor the Platform class in jdk.jpackage to use the internal >> OperatingSystem, Architecture, and Version classes. >> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace >> comparisons in the Platform class. >> The checks of the os.version are replaced but may not be needed if OpenJDK >> no longer supports them. >> >> It is recommended to remove os version checks that apply only to Mac >> versions before 10.15. >> Mac OS X 10.15 is the oldest version supported. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing import of OSVersion Merged with current head and retested. Any other concerns? - PR Comment: https://git.openjdk.org/jdk/pull/13586#issuecomment-1570484204
Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v6]
> Refactor the Platform class in jdk.jpackage to use the internal > OperatingSystem, Architecture, and Version classes. > The OperatingSystem.isXXX() and Architecture.isYYY() methods replace > comparisons in the Platform class. > The checks of the os.version are replaced but may not be needed if OpenJDK no > longer supports them. > > It is recommended to remove os version checks that apply only to Mac versions > before 10.15. > Mac OS X 10.15 is the oldest version supported. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Add missing import of OSVersion - Changes: - all: https://git.openjdk.org/jdk/pull/13586/files - new: https://git.openjdk.org/jdk/pull/13586/files/ab6e20ce..14bf4776 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13586&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13586&range=04-05 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/13586.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13586/head:pull/13586 PR: https://git.openjdk.org/jdk/pull/13586
