Re: RFR: 8308108: Support Unicode extension for collation settings [v5]
On Mon, 22 May 2023 17:59:18 GMT, Naoto Sato wrote: >> This change intends to interpret the BCP47 U extension wrt collation >> settings in the given `Locale`, then applies them to the created instances >> in the 1-arg factory method in `Collator`. A corresponding CSR has also been >> drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Further clarifying the method description Thanks for persisting with this to get the wording clear, the latest version looks good. - Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14040#pullrequestreview-1441043457
Re: RFR: 8308108: Support Unicode extension for collation settings [v5]
On Mon, 22 May 2023 17:59:18 GMT, Naoto Sato wrote: >> This change intends to interpret the BCP47 U extension wrt collation >> settings in the given `Locale`, then applies them to the created instances >> in the 1-arg factory method in `Collator`. A corresponding CSR has also been >> drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Further clarifying the method description Thanks, Alan. Clarified the method doc based on your suggestion. - PR Comment: https://git.openjdk.org/jdk/pull/14040#issuecomment-1557663088
Re: RFR: 8308108: Support Unicode extension for collation settings [v5]
> This change intends to interpret the BCP47 U extension wrt collation settings > in the given `Locale`, then applies them to the created instances in the > 1-arg factory method in `Collator`. A corresponding CSR has also been drafted. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Further clarifying the method description - Changes: - all: https://git.openjdk.org/jdk/pull/14040/files - new: https://git.openjdk.org/jdk/pull/14040/files/1cfc09b6..83cfe984 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=14040=04 - incr: https://webrevs.openjdk.org/?repo=jdk=14040=03-04 Stats: 4 lines in 1 file changed: 0 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/14040.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14040/head:pull/14040 PR: https://git.openjdk.org/jdk/pull/14040
