Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v12]
On Fri, 18 Aug 2023 04:41:25 GMT, sid8606 wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with two additional > commits since the last revision: > > - Calculate the code size. > - Fix missing spcaces Thanks a lot for all discussions, feedback and the reviews! This was really helpful! I'm planning to integrate tomorrow. - PR Comment: https://git.openjdk.org/jdk/pull/14801#issuecomment-1683601556
Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v12]
On Fri, 18 Aug 2023 04:41:25 GMT, sid8606 wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with two additional > commits since the last revision: > > - Calculate the code size. > - Fix missing spcaces Thanks for cleaning it up. LGTM. - Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14801#pullrequestreview-1584089670
Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v12]
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). sid8606 has updated the pull request incrementally with two additional commits since the last revision: - Calculate the code size. - Fix missing spcaces - Changes: - all: https://git.openjdk.org/jdk/pull/14801/files - new: https://git.openjdk.org/jdk/pull/14801/files/a28c92d6..dad186f3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=14801&range=11 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14801&range=10-11 Stats: 11 lines in 3 files changed: 0 ins; 3 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/14801.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14801/head:pull/14801 PR: https://git.openjdk.org/jdk/pull/14801
