Re: RFR: 8313768: Reduce interaction with volatile field in j.u.l.StreamHandler
On Fri, 4 Aug 2023 14:51:35 GMT, Sergey Tsypanov wrote: > In `publish0()`, `flush0()` and `flushAndClose()`methods of `StreamHandler` > we read multiple times from volatile writer. The access number can be reduced > by reading the field into local variable once. The change looks fine to me. I have triggered a CI run and will sponsor once that completes (I don't expect any regressions here given the nature of this change). - Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15161#pullrequestreview-1568845719
Re: RFR: 8313768: Reduce interaction with volatile field in j.u.l.StreamHandler
On Fri, 4 Aug 2023 14:51:35 GMT, Sergey Tsypanov wrote: > In `publish0()`, `flush0()` and `flushAndClose()`methods of `StreamHandler` > we read multiple times from volatile writer. The access number can be reduced > by reading the field into local variable once. LGTM - Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15161#pullrequestreview-1567302875
