Re: RFR: 8313875: Use literals instead of static fields in java.util.Math: twoToTheDoubleScaleUp, twoToTheDoubleScaleDown [v2]
On Mon, 7 Aug 2023 19:44:48 GMT, Andrey Turbanov wrote: >> Couple of static fields in Math are used only once and can be replaced with >> literals `0x1p512`/`0x1p-512 ` > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8313875: Make fields final in java.util.Math: twoToTheDoubleScaleUp, > twoToTheDoubleScaleDown > > completely remove the fields. Use literals instead. Marked as reviewed by rgiulietti (Committer). - PR Review: https://git.openjdk.org/jdk/pull/14875#pullrequestreview-1567008351
Re: RFR: 8313875: Use literals instead of static fields in java.util.Math: twoToTheDoubleScaleUp, twoToTheDoubleScaleDown [v2]
On Mon, 7 Aug 2023 19:44:48 GMT, Andrey Turbanov wrote: >> Couple of static fields in Math are used only once and can be replaced with >> literals `0x1p512`/`0x1p-512 ` > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8313875: Make fields final in java.util.Math: twoToTheDoubleScaleUp, > twoToTheDoubleScaleDown > > completely remove the fields. Use literals instead. >I know, but that's not an official review from the perspective of the OpenJDK, >it's only a GitHub approval. Actually OpenJDK bot use Github approvals as a source. For example see this PR - #13213 Even I'm not a reviewer, my review is still listed in PR description and in the final commit message 30a140b5a2cedc7f69158ce398f148 `Reviewed-by: bpb, prr, aturbanov ` >How would my GitHub approval help you in closing this PR? It's not directly related. You are right. - PR Comment: https://git.openjdk.org/jdk/pull/14875#issuecomment-1669356191
Re: RFR: 8313875: Use literals instead of static fields in java.util.Math: twoToTheDoubleScaleUp, twoToTheDoubleScaleDown [v2]
On Mon, 7 Aug 2023 19:44:48 GMT, Andrey Turbanov wrote: >> Couple of static fields in Math are used only once and can be replaced with >> literals `0x1p512`/`0x1p-512 ` > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8313875: Make fields final in java.util.Math: twoToTheDoubleScaleUp, > twoToTheDoubleScaleDown > > completely remove the fields. Use literals instead. I know, but that's not an _official_ review from the perspective of the OpenJDK, it's only a GitHub approval. I find GitHub "reviews" confusing in the context of OpenJDK. How would my GitHub approval help you in closing this PR? - PR Comment: https://git.openjdk.org/jdk/pull/14875#issuecomment-1669310813
Re: RFR: 8313875: Use literals instead of static fields in java.util.Math: twoToTheDoubleScaleUp, twoToTheDoubleScaleDown [v2]
On Tue, 8 Aug 2023 08:42:05 GMT, Raffaello Giulietti wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8313875: Make fields final in java.util.Math: twoToTheDoubleScaleUp, >> twoToTheDoubleScaleDown >> >> completely remove the fields. Use literals instead. > > LGTM (not a Reviewer) @rgiulietti you still can approve it _officially_, even if you are not a reviewer.  - PR Comment: https://git.openjdk.org/jdk/pull/14875#issuecomment-1669294085
Re: RFR: 8313875: Use literals instead of static fields in java.util.Math: twoToTheDoubleScaleUp, twoToTheDoubleScaleDown [v2]
On Mon, 7 Aug 2023 19:44:48 GMT, Andrey Turbanov wrote: >> Couple of static fields in Math are used only once and can be replaced with >> literals `0x1p512`/`0x1p-512 ` > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8313875: Make fields final in java.util.Math: twoToTheDoubleScaleUp, > twoToTheDoubleScaleDown > > completely remove the fields. Use literals instead. LGTM (not a Reviewer) - PR Comment: https://git.openjdk.org/jdk/pull/14875#issuecomment-1669180764
Re: RFR: 8313875: Use literals instead of static fields in java.util.Math: twoToTheDoubleScaleUp, twoToTheDoubleScaleDown [v2]
On Mon, 7 Aug 2023 19:44:48 GMT, Andrey Turbanov wrote: >> Couple of static fields in Math are used only once and can be replaced with >> literals `0x1p512`/`0x1p-512 ` > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8313875: Make fields final in java.util.Math: twoToTheDoubleScaleUp, > twoToTheDoubleScaleDown > > completely remove the fields. Use literals instead. Marked as reviewed by bpb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14875#pullrequestreview-1566050946
