Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v7]

2023-08-29 Thread Sean Coffey 
> Recursive initialization calls possible during loading of LoggerFinder 
> service.  
> 
> This fix detects the recursive call and returns a temporary LoggerFinder that 
> is backed by a lazy logger. Automated test case developed to simulate loading 
> of an external LoggerFinder service while also having other threads poke 
> System.getLogger during this framework initialization.

Sean Coffey has updated the pull request incrementally with one additional 
commit since the last revision:

  more tidying up in tests

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/15404/files
  - new: https://git.openjdk.org/jdk/pull/15404/files/cf53841b..f8d7545e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15404&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15404&range=05-06

  Stats: 19 lines in 4 files changed: 0 ins; 8 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/15404.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15404/head:pull/15404

PR: https://git.openjdk.org/jdk/pull/15404

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v7]

2023-08-30 Thread Andrey Turbanov 
On Tue, 29 Aug 2023 15:31:03 GMT, Sean Coffey  wrote:

>> Recursive initialization calls possible during loading of LoggerFinder 
>> service.  
>> 
>> This fix detects the recursive call and returns a temporary LoggerFinder 
>> that is backed by a lazy logger. Automated test case developed to simulate 
>> loading of an external LoggerFinder service while also having other threads 
>> poke System.getLogger during this framework initialization.
>
> Sean Coffey has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   more tidying up in tests

test/jdk/java/lang/System/LoggerFinder/SignedLoggerFinderTest/SignedLoggerFinderTest.java
 line 214:

> 212: private static Runnable runnableWithSleep(Supplier s, long sleep, 
> String desc) {
> 213: return () -> {
> 214: while(!testComplete) {

Suggestion:

while (!testComplete) {

-

PR Review Comment: https://git.openjdk.org/jdk/pull/15404#discussion_r1309949039