Re: RFR: 8321114: Rename "Unnamed Classes" to "Implicitly Declared Classes" better [v2]
On Fri, 1 Dec 2023 11:22:33 GMT, Pavel Rappo wrote: >> Please review this PR to correctly rename "Unnamed Class" to "Implicitly >> Declared Class", not "Implicit Class". >> >> Renaming is fixed where it affects documentation or the end-user. Renaming >> is not fixed where it only affects code: it's perfectly okay to derive an >> internal element name from "Implicit Class" rather than "Implicitly Declared >> Class", for brevity. > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Remove a comment typo introduced in JEP 445 Marked as reviewed by jlaskey (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16904#pullrequestreview-1759655045
Re: RFR: 8321114: Rename "Unnamed Classes" to "Implicitly Declared Classes" better [v2]
On Thu, 30 Nov 2023 16:11:01 GMT, Jim Laskey wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove a comment typo introduced in JEP 445 > > LGTM @JimLaskey please re-review this PR due to a newly pushed [3676b50](https://github.com/openjdk/jdk/pull/16904/commits/3676b500834cd5e91b5829545e3fed71e43312a7). Also, please double-check if the comment is still valid factually. - PR Comment: https://git.openjdk.org/jdk/pull/16904#issuecomment-1835914750
Re: RFR: 8321114: Rename "Unnamed Classes" to "Implicitly Declared Classes" better [v2]
> Please review this PR to correctly rename "Unnamed Class" to "Implicitly > Declared Class", not "Implicit Class". > > Renaming is fixed where it affects documentation or the end-user. Renaming is > not fixed where it only affects code: it's perfectly okay to derive an > internal element name from "Implicit Class" rather than "Implicitly Declared > Class", for brevity. Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision: Remove a comment typo introduced in JEP 445 - Changes: - all: https://git.openjdk.org/jdk/pull/16904/files - new: https://git.openjdk.org/jdk/pull/16904/files/089aeee2..3676b500 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=16904&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16904&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/16904.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16904/head:pull/16904 PR: https://git.openjdk.org/jdk/pull/16904
