Re: RFR: 8321124: java/util/stream/GatherersTest.java times out [v5]
On Tue, 5 Dec 2023 14:55:02 GMT, Viktor Klang wrote:
>> Splits GatherersTest out to distinct files per built-in gatherer
>>
>> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on
>> the ProblemList.
>>
>> Adding increased maxOutputSize for Gatherer-related tests to improve
>> debuggability.
>>
>> Lowering the composition threshold of
>> GathererTest.testMassivelyComposedGatherers to 256 to avoid SOE on
>> low-specc:ed machines.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressing review feedback: improving test coverage and debuggability
test/jdk/java/util/stream/GatherersMapConcurrentTest.java line 254:
> 252: fail("Unexpected!");
> 253: }
> 254: while(tasksWaiting.getQueueLength() <
> tasksToCancel) {
Suggestion:
while (tasksWaiting.getQueueLength() <
tasksToCancel) {
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16928#discussion_r1416171352
Re: RFR: 8321124: java/util/stream/GatherersTest.java times out [v5]
On Tue, 5 Dec 2023 14:55:02 GMT, Viktor Klang wrote: >> Splits GatherersTest out to distinct files per built-in gatherer >> >> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on >> the ProblemList. >> >> Adding increased maxOutputSize for Gatherer-related tests to improve >> debuggability. >> >> Lowering the composition threshold of >> GathererTest.testMassivelyComposedGatherers to 256 to avoid SOE on >> low-specc:ed machines. > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision: > > Addressing review feedback: improving test coverage and debuggability Thank you for fixing GHA failure. I am not doing review since I am not expert. - PR Comment: https://git.openjdk.org/jdk/pull/16928#issuecomment-1841337736
Re: RFR: 8321124: java/util/stream/GatherersTest.java times out [v5]
On Tue, 5 Dec 2023 14:55:02 GMT, Viktor Klang wrote: >> Splits GatherersTest out to distinct files per built-in gatherer >> >> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on >> the ProblemList. >> >> Adding increased maxOutputSize for Gatherer-related tests to improve >> debuggability. >> >> Lowering the composition threshold of >> GathererTest.testMassivelyComposedGatherers to 256 to avoid SOE on >> low-specc:ed machines. > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision: > > Addressing review feedback: improving test coverage and debuggability Thanks for the updates/refactoring, I don't have any more comments to add. - Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16928#pullrequestreview-1765642282
Re: RFR: 8321124: java/util/stream/GatherersTest.java times out [v5]
> Splits GatherersTest out to distinct files per built-in gatherer > > Fixes a test ordering issue for mapConcurrent which placed GatherersTest on > the ProblemList. > > Adding increased maxOutputSize for Gatherer-related tests to improve > debuggability. > > Lowering the composition threshold of > GathererTest.testMassivelyComposedGatherers to 256 to avoid SOE on > low-specc:ed machines. Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: Addressing review feedback: improving test coverage and debuggability - Changes: - all: https://git.openjdk.org/jdk/pull/16928/files - new: https://git.openjdk.org/jdk/pull/16928/files/fd426ae7..663a7b64 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=16928=04 - incr: https://webrevs.openjdk.org/?repo=jdk=16928=03-04 Stats: 76 lines in 1 file changed: 49 ins; 9 del; 18 mod Patch: https://git.openjdk.org/jdk/pull/16928.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16928/head:pull/16928 PR: https://git.openjdk.org/jdk/pull/16928
