Re: RFR: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable [v2]
On Fri, 5 Jan 2024 08:22:41 GMT, Stefan Karlsson wrote: >> Most functions in ProcessTools are declared to throw Exceptions, or one of >> its subclasses. However, there are a small number of functions that are >> unnecessarily declared to throw Throwable instead of Exception. I propose >> that we change them to also be declared to throw Exception. >> >> This is a trivial patch to make it easier to refactor tests to use the >> updated functions. >> >> Tested manually, but will wait for GHA to verify that the change is OK. > > Stefan Karlsson has updated the pull request incrementally with one > additional commit since the last revision: > > Copyright year Thanks for the reviews. Testing with Tier1-3 passes. - PR Comment: https://git.openjdk.org/jdk/pull/17240#issuecomment-1878341513
Re: RFR: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable [v2]
> Most functions in ProcessTools are declared to throw Exceptions, or one of > its subclasses. However, there are a small number of functions that are > unnecessarily declared to throw Throwable instead of Exception. I propose > that we change them to also be declared to throw Exception. > > This is a trivial patch to make it easier to refactor tests to use the > updated functions. > > Tested manually, but will wait for GHA to verify that the change is OK. Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision: Copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/17240/files - new: https://git.openjdk.org/jdk/pull/17240/files/910a863c..402b6727 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17240=01 - incr: https://webrevs.openjdk.org/?repo=jdk=17240=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17240.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17240/head:pull/17240 PR: https://git.openjdk.org/jdk/pull/17240
