Re: RFR: 8323659: LinkedTransferQueue add and put methods call overridable offer [v5]
On Mon, 15 Jan 2024 12:09:48 GMT, Chris Hegarty wrote: >> Update LinkedTransferQueue add and put methods to not call overridable offer. > > Chris Hegarty has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Merge branch 'master' into ltq_bug > - Update > src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java > >Co-authored-by: Andrey Turbanov > - timed offer > - add test > - Update LinkedTransferQueue add and put methods to not call overridable > offer Marked as reviewed by alanb (Reviewer). test/jdk/java/util/concurrent/LinkedTransferQueue/SubclassTest.java line 28: > 26: * @run testng SubclassTest > 27: * @bug 8323659 > 28: * @summary Ensures that the implementation of LTQ add and put methods > does [ORDER OF TAGS](https://openjdk.org/jtreg/tag-spec.html#ORDER) - PR Review: https://git.openjdk.org/jdk/pull/17393#pullrequestreview-1822096706 PR Review Comment: https://git.openjdk.org/jdk/pull/17393#discussion_r1452638878
Re: RFR: 8323659: LinkedTransferQueue add and put methods call overridable offer [v5]
On Mon, 15 Jan 2024 12:34:57 GMT, Doug Lea wrote: > Sorry for needlessly calling overridable versions in these two cases. I > should have caught that. No problem, easy to overlook. I assume you are ok with the changes? If so, could I please ask you to add your review. Otherwise, is there another way that we should proceed? - PR Comment: https://git.openjdk.org/jdk/pull/17393#issuecomment-1892569945
Re: RFR: 8323659: LinkedTransferQueue add and put methods call overridable offer [v5]
On Mon, 15 Jan 2024 12:09:48 GMT, Chris Hegarty wrote: >> Update LinkedTransferQueue add and put methods to not call overridable offer. > > Chris Hegarty has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Merge branch 'master' into ltq_bug > - Update > src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java > >Co-authored-by: Andrey Turbanov > - timed offer > - add test > - Update LinkedTransferQueue add and put methods to not call overridable > offer Sorry for needlessly calling overridable versions in these two cases. I should have caught that. - PR Comment: https://git.openjdk.org/jdk/pull/17393#issuecomment-1892095964
Re: RFR: 8323659: LinkedTransferQueue add and put methods call overridable offer [v5]
> Update LinkedTransferQueue add and put methods to not call overridable offer. Chris Hegarty has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'master' into ltq_bug - Update src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java Co-authored-by: Andrey Turbanov - timed offer - add test - Update LinkedTransferQueue add and put methods to not call overridable offer - Changes: - all: https://git.openjdk.org/jdk/pull/17393/files - new: https://git.openjdk.org/jdk/pull/17393/files/22f2857c..72ad71fb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17393=04 - incr: https://webrevs.openjdk.org/?repo=jdk=17393=03-04 Stats: 11818 lines in 198 files changed: 5468 ins; 5671 del; 679 mod Patch: https://git.openjdk.org/jdk/pull/17393.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17393/head:pull/17393 PR: https://git.openjdk.org/jdk/pull/17393
