Re: RFR: 8326126: Update the java manpage with the changes from JDK-8322478

2024-02-19 Thread David Holmes
On Mon, 19 Feb 2024 07:04:07 GMT, David Holmes  wrote:

> Please reviews these manpage updates in relation to "JEP 458: Launch 
> Multi-File Source-Code Programs".  The manpage sources had previously been 
> updated internally at Oracle under JDK-8322478, but the open troff file was 
> not regenerated at the time in mainline (it was for JDK 22).
> 
> The main gist of the change is that with multi-file support now available,  
> occurrences of "single source-file" should just refer to "source-file".
> 
> Thanks

Thanks for the reviews!

-

PR Comment: https://git.openjdk.org/jdk/pull/17908#issuecomment-1953205703


Re: RFR: 8326126: Update the java manpage with the changes from JDK-8322478

2024-02-19 Thread Christian Stein
On Mon, 19 Feb 2024 07:04:07 GMT, David Holmes  wrote:

> Please reviews these manpage updates in relation to "JEP 458: Launch 
> Multi-File Source-Code Programs".  The manpage sources had previously been 
> updated internally at Oracle under JDK-8322478, but the open troff file was 
> not regenerated at the time in mainline (it was for JDK 22).
> 
> The main gist of the change is that with multi-file support now available,  
> occurrences of "single source-file" should just refer to "source-file".
> 
> Thanks

Marked as reviewed by cstein (Committer).

-

PR Review: https://git.openjdk.org/jdk/pull/17908#pullrequestreview-1888038946


Re: RFR: 8326126: Update the java manpage with the changes from JDK-8322478

2024-02-19 Thread Alan Bateman
On Mon, 19 Feb 2024 07:04:07 GMT, David Holmes  wrote:

> Please reviews these manpage updates in relation to "JEP 458: Launch 
> Multi-File Source-Code Programs".  The manpage sources had previously been 
> updated internally at Oracle under JDK-8322478, but the open troff file was 
> not regenerated at the time in mainline (it was for JDK 22).
> 
> The main gist of the change is that with multi-file support now available,  
> occurrences of "single source-file" should just refer to "source-file".
> 
> Thanks

Marked as reviewed by alanb (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/17908#pullrequestreview-1887772261