Re: RFR: 8327705: Remove mention of "applet" from java.text package description [v2]

2024-03-11 Thread Alan Bateman
On Mon, 11 Mar 2024 16:32:31 GMT, Naoto Sato  wrote:

>> Removing left over "applet" mention in the package-info doc.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressing review comments

Marked as reviewed by alanb (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1929194427


Re: RFR: 8327705: Remove mention of "applet" from java.text package description [v2]

2024-03-11 Thread Roger Riggs
On Mon, 11 Mar 2024 16:32:31 GMT, Naoto Sato  wrote:

>> Removing left over "applet" mention in the package-info doc.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressing review comments

Marked as reviewed by rriggs (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1928607470


Re: RFR: 8327705: Remove mention of "applet" from java.text package description [v2]

2024-03-11 Thread Iris Clark
On Mon, 11 Mar 2024 16:32:31 GMT, Naoto Sato  wrote:

>> Removing left over "applet" mention in the package-info doc.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressing review comments

Marked as reviewed by iris (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1928697079


Re: RFR: 8327705: Remove mention of "applet" from java.text package description [v2]

2024-03-11 Thread Brian Burkhalter
On Mon, 11 Mar 2024 16:32:31 GMT, Naoto Sato  wrote:

>> Removing left over "applet" mention in the package-info doc.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressing review comments

Marked as reviewed by bpb (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1928572972


Re: RFR: 8327705: Remove mention of "applet" from java.text package description [v2]

2024-03-11 Thread Naoto Sato
On Sat, 9 Mar 2024 11:12:35 GMT, Alan Bateman  wrote:

>> Naoto Sato has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Addressing review comments
>
> src/java.base/share/classes/java/text/package-info.java line 29:
> 
>> 27:  * Provides classes and interfaces for handling text, dates, numbers,
>> 28:  * and messages in a manner independent of natural languages.  This
>> 29:  * means your application can be written to be
> 
> Maybe it should be broadened a bit, e.g  "an application or library" instead 
> of "your application".

Thanks. Broadened.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/18173#discussion_r1519900595


Re: RFR: 8327705: Remove mention of "applet" from java.text package description [v2]

2024-03-11 Thread Naoto Sato
> Removing left over "applet" mention in the package-info doc.

Naoto Sato has updated the pull request incrementally with one additional 
commit since the last revision:

  Addressing review comments

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/18173/files
  - new: https://git.openjdk.org/jdk/pull/18173/files/9b5429d3..95d1dca8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=18173=01
 - incr: https://webrevs.openjdk.org/?repo=jdk=18173=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18173.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18173/head:pull/18173

PR: https://git.openjdk.org/jdk/pull/18173


Re: RFR: 8327705: Remove mention of "applet" from java.text package description

2024-03-09 Thread Alan Bateman
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato  wrote:

> Removing left over "applet" mention in the package-info doc.

src/java.base/share/classes/java/text/package-info.java line 29:

> 27:  * Provides classes and interfaces for handling text, dates, numbers,
> 28:  * and messages in a manner independent of natural languages.  This
> 29:  * means your application can be written to be

Maybe we should be broadened a bit, e.g  "an application or library" instead of 
"your application".

-

PR Review Comment: https://git.openjdk.org/jdk/pull/18173#discussion_r1518556238


Re: RFR: 8327705: Remove mention of "applet" from java.text package description

2024-03-09 Thread Guoxiong Li
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato  wrote:

> Removing left over "applet" mention in the package-info doc.

Marked as reviewed by gli (Committer).

-

PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1926166255


Re: RFR: 8327705: Remove mention of "applet" from java.text package description

2024-03-08 Thread Justin Lu
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato  wrote:

> Removing left over "applet" mention in the package-info doc.

Marked as reviewed by jlu (Committer).

-

PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1925828046


Re: RFR: 8327705: Remove mention of "applet" from java.text package description

2024-03-08 Thread Iris Clark
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato  wrote:

> Removing left over "applet" mention in the package-info doc.

Marked as reviewed by iris (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1925813600


Re: RFR: 8327705: Remove mention of "applet" from java.text package description

2024-03-08 Thread Roger Riggs
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato  wrote:

> Removing left over "applet" mention in the package-info doc.

bye bye

-

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1925798262


Re: RFR: 8327705: Remove mention of "applet" from java.text package description

2024-03-08 Thread Brian Burkhalter
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato  wrote:

> Removing left over "applet" mention in the package-info doc.

Farewell applets.

-

Marked as reviewed by bpb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1925759402