Re: RFR: 8330542: Add two sample configuration files in preparation for a more secure by default configuration [v2]

2024-04-19 Thread Joe Wang
On Thu, 18 Apr 2024 23:40:22 GMT, Naoto Sato  wrote:

>> Joe Wang has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   add description of the three configuration files.
>
> src/java.xml/share/conf/jaxp-strict.properties line 2:
> 
>> 1: 
>> 
>> 2: #   JAXP String Configuration File
> 
> Nit: typo here: String -> Strict

Thanks!  Fixed.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/18831#discussion_r1572705283


Re: RFR: 8330542: Add two sample configuration files in preparation for a more secure by default configuration [v2]

2024-04-18 Thread Naoto Sato
On Thu, 18 Apr 2024 21:54:26 GMT, Joe Wang  wrote:

>> Add two sample configuration files:
>> 
>>   jaxp-strict.properties: used to set strict configuration, stricter than 
>> jaxp.properties in previous versions such as JDK 22
>> 
>>   jaxp-compat.properties: used to regain compatibility from any more 
>> restricted configuration than previous versions such as JDK 22
>
> Joe Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   add description of the three configuration files.

src/java.xml/share/conf/jaxp-strict.properties line 2:

> 1: 
> 
> 2: #   JAXP String Configuration File

Nit: typo here: String -> Strict

-

PR Review Comment: https://git.openjdk.org/jdk/pull/18831#discussion_r1571515112


Re: RFR: 8330542: Add two sample configuration files in preparation for a more secure by default configuration [v2]

2024-04-18 Thread Joe Wang
> Add two sample configuration files:
> 
>   jaxp-strict.properties: used to set strict configuration, stricter than 
> jaxp.properties in previous versions such as JDK 22
> 
>   jaxp-compat.properties: used to regain compatibility from any more 
> restricted configuration than previous versions such as JDK 22

Joe Wang has updated the pull request incrementally with one additional commit 
since the last revision:

  add description of the three configuration files.

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/18831/files
  - new: https://git.openjdk.org/jdk/pull/18831/files/e36e5fd4..98fcc3ef

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=18831=01
 - incr: https://webrevs.openjdk.org/?repo=jdk=18831=00-01

  Stats: 44 lines in 2 files changed: 38 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/18831.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18831/head:pull/18831

PR: https://git.openjdk.org/jdk/pull/18831