Re: RFR: 8331077 : nroff man page update for jar tool [v2]
On Wed, 1 May 2024 18:42:12 GMT, Weibing Xiao wrote: >> nroff man page update for jar tool. >> This update is caused by the change of >> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got >> updated in other repos, the corresponding nroff man page was never updated >> in OpenJDK repos > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > version of java Approved, as corresponding to the upstream Markdown file. That being said, the descriptions about arg files in lines 334-343 look somewhat clunky, and could benefit from some improvements in a later update. - Marked as reviewed by jjg (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19039#pullrequestreview-2034355345
Re: RFR: 8331077 : nroff man page update for jar tool [v2]
On Wed, 1 May 2024 18:42:12 GMT, Weibing Xiao wrote: >> nroff man page update for jar tool. >> This update is caused by the change of >> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got >> updated in other repos, the corresponding nroff man page was never updated >> in OpenJDK repos > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > version of java Looks ok to me - Marked as reviewed by coffeys (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19039#pullrequestreview-2034212366
Re: RFR: 8331077 : nroff man page update for jar tool
On Wed, 1 May 2024 17:52:13 GMT, Weibing Xiao wrote: > nroff man page update for jar tool. > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos reverted to "JDK 23-ea" - PR Comment: https://git.openjdk.org/jdk/pull/19039#issuecomment-2088901772
Re: RFR: 8331077 : nroff man page update for jar tool [v2]
> nroff man page update for jar tool. > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: version of java - Changes: - all: https://git.openjdk.org/jdk/pull/19039/files - new: https://git.openjdk.org/jdk/pull/19039/files/2808853c..b0ef5dff Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19039=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19039=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19039.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19039/head:pull/19039 PR: https://git.openjdk.org/jdk/pull/19039
Re: RFR: 8331077 : nroff man page update for jar tool
On Wed, 1 May 2024 17:52:13 GMT, Weibing Xiao wrote: > nroff man page update for jar tool. > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos Changes requested by jjg (Reviewer). src/jdk.jartool/share/man/jar.1 line 38: > 36: . ftr VBI CBI > 37: .\} > 38: .TH "JAR" "1" "2024" "JDK 23-internal" "JDK Commands" should remain as `ea` -- not `internal` - PR Review: https://git.openjdk.org/jdk/pull/19039#pullrequestreview-2034148426 PR Review Comment: https://git.openjdk.org/jdk/pull/19039#discussion_r1586584726
Re: RFR: 8331077 : nroff man page update for jar tool [v3]
On Wed, 1 May 2024 16:15:12 GMT, Weibing Xiao wrote: >> nroff man page update for jar tool. >> >> This update is caused by the change of >> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got >> updated in other repos, the corresponding nroff man page was never updated >> in OpenJDK repos > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > Revert "8331427: Rename confusingly named ArraysSupport.signedHashCode" > > This reverts commit 4f529f8c232b4082aa4aa39766bcf42b09885ee4. Close this one as I plan to use make command to update this nroff man page. - PR Comment: https://git.openjdk.org/jdk/pull/19034#issuecomment-2088703685
Re: RFR: 8331077 : nroff man page update for jar tool [v3]
> nroff man page update for jar tool. > > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: Revert "8331427: Rename confusingly named ArraysSupport.signedHashCode" This reverts commit 4f529f8c232b4082aa4aa39766bcf42b09885ee4. - Changes: - all: https://git.openjdk.org/jdk/pull/19034/files - new: https://git.openjdk.org/jdk/pull/19034/files/333dbc36..051da56e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19034=02 - incr: https://webrevs.openjdk.org/?repo=jdk=19034=01-02 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/19034.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19034/head:pull/19034 PR: https://git.openjdk.org/jdk/pull/19034
Re: RFR: 8331077 : nroff man page update for jar tool [v2]
> nroff man page update for jar tool. > > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the year of copyright - Changes: - all: https://git.openjdk.org/jdk/pull/19034/files - new: https://git.openjdk.org/jdk/pull/19034/files/c78bc5dd..333dbc36 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19034=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19034=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19034.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19034/head:pull/19034 PR: https://git.openjdk.org/jdk/pull/19034
