Re: RFR: 8331202: Support for Duration until another Instant [v3]
On Wed, 1 May 2024 17:21:20 GMT, Naoto Sato wrote: >> A new method on Instant to return the duration `until` another Instant is >> suggested per the following discussion thread: >> >> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html >> >> A CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Addressing CSR reviews Hearing no further comments, integrating this PR. - PR Comment: https://git.openjdk.org/jdk/pull/19007#issuecomment-2115651450
Re: RFR: 8331202: Support for Duration until another Instant [v3]
On Wed, 1 May 2024 17:21:20 GMT, Naoto Sato wrote: >> A new method on Instant to return the duration `until` another Instant is >> suggested per the following discussion thread: >> >> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html >> >> A CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Addressing CSR reviews +1 to Roger's observation. Adding a conceptually different `minus` method would be confusing. - PR Comment: https://git.openjdk.org/jdk/pull/19007#issuecomment-2090926275
Re: RFR: 8331202: Support for Duration until another Instant [v3]
On Wed, 1 May 2024 17:21:20 GMT, Naoto Sato wrote: >> A new method on Instant to return the duration `until` another Instant is >> suggested per the following discussion thread: >> >> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html >> >> A CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Addressing CSR reviews @kluever Your comment isn't visible yet, there's a checkbox to accept OpenJDK terms. It would be good to know what you've commented. My reservation about `minus(Instant)` is that all of the current `minus(...)` methods return an `Instant` as do the `plus(...)` methods. Adding a `minus` method that returns `Duration` adds a bit of fuzziness to the plus and minus method uses. A similar concern could be raised about adding `Duration until(Instant)` as there is already a `until(Temporarl, TemporalUnit)` method. But there is smaller opportunity to mix them up. - PR Comment: https://git.openjdk.org/jdk/pull/19007#issuecomment-2090693079
Re: RFR: 8331202: Support for Duration until another Instant [v3]
On Wed, 1 May 2024 17:21:20 GMT, Naoto Sato wrote: >> A new method on Instant to return the duration `until` another Instant is >> suggested per the following discussion thread: >> >> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html >> >> A CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Addressing CSR reviews Hi, I'm on the same team as Kurt (@kluever) and I'd like to note that we think this PR is a little premature. Discussion on the core-libs-dev thread wasn't conclusive and we're not yet convinced that `until` is better than the `minus` that was originally proposed. Can we hold off for a bit while discussion on the thread continues? - PR Comment: https://git.openjdk.org/jdk/pull/19007#issuecomment-2090505385
Re: RFR: 8331202: Support for Duration until another Instant [v3]
On Wed, 1 May 2024 17:21:20 GMT, Naoto Sato wrote: >> A new method on Instant to return the duration `until` another Instant is >> suggested per the following discussion thread: >> >> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html >> >> A CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Addressing CSR reviews Marked as reviewed by rriggs (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19007#pullrequestreview-2034423684
Re: RFR: 8331202: Support for Duration until another Instant [v3]
> A new method on Instant to return the duration `until` another Instant is > suggested per the following discussion thread: > > https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html > > A CSR has also been drafted. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Addressing CSR reviews - Changes: - all: https://git.openjdk.org/jdk/pull/19007/files - new: https://git.openjdk.org/jdk/pull/19007/files/df2c1157..cccdf00c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19007=02 - incr: https://webrevs.openjdk.org/?repo=jdk=19007=01-02 Stats: 11 lines in 1 file changed: 0 ins; 7 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/19007.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19007/head:pull/19007 PR: https://git.openjdk.org/jdk/pull/19007