Re: RFR: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
On Thu, 2 May 2024 21:19:14 GMT, Phil Race wrote: > I see you added test.lib.Platform.isOnWayland() in this PR > https://github.com/openjdk/jdk/pull/18995/files#diff-a1fe81399728999601f16ae9aaf5caae27f009c394377d2cd86c71f6d5e0e54c > > So, that helps me understand why it is a new problem, but I still don't > understand why the failing test cares. The test was introduced by [JDK-8058846](https://bugs.openjdk.org/browse/JDK-8058846). Its title is self-explanatory "c.o.j.t.Platform::isX86 and isX64 may simultaneously return true" So methods that should not be true at the same time are placed in different groups, or in ignored group. https://github.com/openjdk/jdk/blob/master/test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java#L48-L52 The test also checks if there is a new method that is not in any of these groups, hence the failure - PR Comment: https://git.openjdk.org/jdk/pull/19071#issuecomment-2091738433
Re: RFR: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
On Thu, 2 May 2024 21:05:38 GMT, Alexander Zvegintsev wrote: > Trivial fix. Marked as reviewed by prr (Reviewer). OK. I see. The problem is that the test is out of sync with the actual usage of Platform. Arguably isOnWayland() and all these others should be in some OTHER class entirely. Something like PlatformAttribute.java or JDKBuildAttribute.java - PR Review: https://git.openjdk.org/jdk/pull/19071#pullrequestreview-2036959388 PR Comment: https://git.openjdk.org/jdk/pull/19071#issuecomment-2091703042
Re: RFR: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
On Thu, 2 May 2024 21:05:38 GMT, Alexander Zvegintsev wrote: > Trivial fix. I see you added test.lib.Platform.isOnWayland() in this PR https://github.com/openjdk/jdk/pull/18995/files#diff-a1fe81399728999601f16ae9aaf5caae27f009c394377d2cd86c71f6d5e0e54c So, that helps me understand why it is a new problem, but I still don't understand why the failing test cares. - PR Comment: https://git.openjdk.org/jdk/pull/19071#issuecomment-2091670387
Re: RFR: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
On Thu, 2 May 2024 21:05:38 GMT, Alexander Zvegintsev wrote: > Trivial fix. I'd love to approve this but could you please explain what this is about ? I see the failure log in the bug report but I am none the wiser. Why exactly is this a problem ? - PR Comment: https://git.openjdk.org/jdk/pull/19071#issuecomment-2091639231
