Re: RFR: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\\A\\Z' missing from stderr [v2]
On Mon, 20 May 2024 07:27:19 GMT, Axel Boldt-Christmas wrote: >> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring >> deprecated warnings. Testing non-generational ZGC requires the use of a >> deprecated option. > > Axel Boldt-Christmas has updated the pull request incrementally with one > additional commit since the last revision: > > Update copyright year Thanks for the reviews. - PR Comment: https://git.openjdk.org/jdk/pull/19297#issuecomment-2121826396
Re: RFR: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\\A\\Z' missing from stderr [v2]
On Mon, 20 May 2024 11:41:48 GMT, Axel Boldt-Christmas
wrote:
>> test/lib/jdk/test/lib/process/OutputAnalyzer.java line 691:
>>
>>> 689: * @throws RuntimeException If the pattern was not found
>>> 690: */
>>> 691: public OutputAnalyzer
>>> stderrShouldMatchIgnoreDeprecatedWarnings(String pattern) {
>>
>> Given we have `...IgnoreVMWarnings` this special case should really be
>> called `...IgnoreDeprecatedVMWarnings`.
>
> The name was chosen based on:
> https://github.com/openjdk/jdk/blob/77c8516085225a04bd5a954197fc5ef7e5c5ee61/test/lib/jdk/test/lib/process/OutputAnalyzer.java#L184
>
> Should I still change it?
No. Sorry I missed the fact the inconsistency had already been introduced. And
given that function exists we may as well add the new one too.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19297#discussion_r1607458481
Re: RFR: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\\A\\Z' missing from stderr [v2]
On Mon, 20 May 2024 07:27:19 GMT, Axel Boldt-Christmas wrote: >> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring >> deprecated warnings. Testing non-generational ZGC requires the use of a >> deprecated option. > > Axel Boldt-Christmas has updated the pull request incrementally with one > additional commit since the last revision: > > Update copyright year looks good. Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19297#pullrequestreview-2067288156
Re: RFR: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\\A\\Z' missing from stderr [v2]
On Mon, 20 May 2024 10:11:26 GMT, David Holmes wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright year
>
> test/lib/jdk/test/lib/process/OutputAnalyzer.java line 691:
>
>> 689: * @throws RuntimeException If the pattern was not found
>> 690: */
>> 691: public OutputAnalyzer
>> stderrShouldMatchIgnoreDeprecatedWarnings(String pattern) {
>
> Given we have `...IgnoreVMWarnings` this special case should really be called
> `...IgnoreDeprecatedVMWarnings`.
The name was chosen based on:
https://github.com/openjdk/jdk/blob/77c8516085225a04bd5a954197fc5ef7e5c5ee61/test/lib/jdk/test/lib/process/OutputAnalyzer.java#L184
Should I still change it?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19297#discussion_r1606671332
Re: RFR: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\\A\\Z' missing from stderr [v2]
On Mon, 20 May 2024 07:27:19 GMT, Axel Boldt-Christmas
wrote:
>> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring
>> deprecated warnings. Testing non-generational ZGC requires the use of a
>> deprecated option.
>
> Axel Boldt-Christmas has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update copyright year
I'm undecided whether it is really worth adding a new utility function to just
ignore deprecated warnings, or whether we should just use the existing function
to ignore all warnings.
If we special case for deprecated warnings then we may want to also add a
special version of `asLinesWithoutVMWarnings`
test/lib/jdk/test/lib/process/OutputAnalyzer.java line 691:
> 689: * @throws RuntimeException If the pattern was not found
> 690: */
> 691: public OutputAnalyzer
> stderrShouldMatchIgnoreDeprecatedWarnings(String pattern) {
Given we have `...IgnoreVMWarnings` this special case should really be called
`...IgnoreDeprecatedVMWarnings`.
-
PR Review: https://git.openjdk.org/jdk/pull/19297#pullrequestreview-2065863128
PR Review Comment: https://git.openjdk.org/jdk/pull/19297#discussion_r1606551444
Re: RFR: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\\A\\Z' missing from stderr [v2]
On Mon, 20 May 2024 07:27:19 GMT, Axel Boldt-Christmas wrote: >> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring >> deprecated warnings. Testing non-generational ZGC requires the use of a >> deprecated option. > > Axel Boldt-Christmas has updated the pull request incrementally with one > additional commit since the last revision: > > Update copyright year Marked as reviewed by jpai (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19297#pullrequestreview-2065548780
Re: RFR: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\\A\\Z' missing from stderr [v2]
> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring > deprecated warnings. Testing non-generational ZGC requires the use of a > deprecated option. Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision: Update copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/19297/files - new: https://git.openjdk.org/jdk/pull/19297/files/d25cde7c..77c85160 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19297=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19297=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19297.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19297/head:pull/19297 PR: https://git.openjdk.org/jdk/pull/19297
Re: RFR: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\\A\\Z' missing from stderr [v2]
On Mon, 20 May 2024 07:24:16 GMT, Axel Boldt-Christmas wrote: >> Improve `java/util/zip/EntryCount64k.java` stderr parsing by ignoring >> deprecated warnings. Testing non-generational ZGC requires the use of a >> deprecated option. > > Axel Boldt-Christmas has updated the pull request incrementally with one > additional commit since the last revision: > > Update copyright year Marked as reviewed by stefank (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19297#pullrequestreview-2065538663
