Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v11]

2022-11-18 Thread Andrew Haley 
> JEP 429 implementation.

Andrew Haley has updated the pull request incrementally with one additional 
commit since the last revision:

  Reviewer feedback

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/10952/files
  - new: https://git.openjdk.org/jdk/pull/10952/files/280cd6c5..d9e5979f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10952&range=10
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10952&range=09-10

  Stats: 19 lines in 2 files changed: 8 ins; 0 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/10952.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10952/head:pull/10952

PR: https://git.openjdk.org/jdk/pull/10952

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v11]

2022-11-18 Thread Alan Bateman 
On Fri, 18 Nov 2022 15:05:42 GMT, Andrew Haley  wrote:

>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Reviewer feedback

src/java.base/share/classes/java/lang/Thread.java line 787:

> 785: 
> 786: // special value to mean a new thread
> 787: this.scopedValueBindings = Thread.class;

The addition of NEW_THREAD_BINDINGS means this one should change too. The 
update means the comment should probably be adjusted too, maybe  "initial value 
for a new thread".

-

PR: https://git.openjdk.org/jdk/pull/10952

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v11]

2022-11-23 Thread Andrew Haley 
On Fri, 18 Nov 2022 15:19:35 GMT, Alan Bateman  wrote:

>> Andrew Haley has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Reviewer feedback
>
> src/java.base/share/classes/java/lang/Thread.java line 787:
> 
>> 785: 
>> 786: // special value to mean a new thread
>> 787: this.scopedValueBindings = Thread.class;
> 
> The addition of NEW_THREAD_BINDINGS means this one should change too. The 
> update means the comment should probably be adjusted too, maybe  "initial 
> value for a new thread".

Done

-

PR: https://git.openjdk.org/jdk/pull/10952