Re: RFR: JDK-8289798: Update to use jtreg 7 [v6]
On Mon, 5 Sep 2022 07:38:33 GMT, Thomas Stuefe wrote: > So I guess at the minimum we would have to downport those test changes to be > able to test older JDKs with the new jtreg, right? Yes. Otherwise those tests will fail as they still do depend on hard-coded names of 3rd-party JAR files. Find backport candidates listed as Sub-Tasks number 3 to 5 at https://bugs.openjdk.org/browse/JDK-8289798 (Sub-Tasks number 1 and 2 were closed without changes.) - PR: https://git.openjdk.org/jdk/pull/9393
Re: RFR: JDK-8289798: Update to use jtreg 7 [v6]
On Mon, 5 Sep 2022 07:18:09 GMT, Christian Stein wrote: > > Is jtreg 7 downward compatible? Can I use it to test older JDKs, if yes, > > down to which version? > > Yes, down to JDK 11. > > Quote from [Coming soon: jtreg > 7](https://mail.openjdk.org/pipermail/jdk-dev/2022-August/006869.html) > > > Also starting with version 7, jtreg is compiled with JDK 11 and so requires > > a recent release of JDK 11 to run it. I read this to mean JT_JAVA, so the JVM running jtreg, not the testee VM. But you are saying that the testee VM (`-jdk` option) can be JDK11 or later? I wonder whether I can use jtreg7 to test downport JDKs, especially since you wrote "This did affect some existing JDK tests, but those tests that relied on specific jar file names have already been updated." So I guess at the minimum we would have to downport those test changes to be able to test older JDKs with the new jtreg, right? - PR: https://git.openjdk.org/jdk/pull/9393
Re: RFR: JDK-8289798: Update to use jtreg 7 [v6]
On Mon, 5 Sep 2022 06:36:04 GMT, Thomas Stuefe wrote: > Is jtreg 7 downward compatible? Can I use it to test older JDKs, if yes, down > to which version? Yes, down to JDK 11. Quote from [Coming soon: jtreg 7](https://mail.openjdk.org/pipermail/jdk-dev/2022-August/006869.html) > Also starting with version 7, jtreg is compiled with JDK 11 and so requires a > recent release of JDK 11 to run it. And it should have said more correctly: _...requires a recent release of JDK 11 **or later** to run it._ - PR: https://git.openjdk.org/jdk/pull/9393
Re: RFR: JDK-8289798: Update to use jtreg 7 [v6]
On Mon, 5 Sep 2022 06:12:18 GMT, Christian Stein wrote: >> Please review the change to update to using jtreg 7. >> >> The primary change is to the `jib-profiles.js` file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the `requiredVersion` has been updated in the various `TEST.ROOT` >> files. > > Christian Stein has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 14 commits: > > - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 > - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 > - Update configure to check for jtreg 7 or later > - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 > - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 > - Revert junit.java > >Commit > https://github.com/openjdk/jdk/commit/45c3e898ed538545921395372fe507e9111401e1 > deleted this file > - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 > - Update to new JUnit JAR file > >With version 7 of `jtreg` comes JUnit Platform 1.8.2 (also known as "JUnit > 5.8.2"). >This change updates the hard-coded library tag value to the new JUnit JAR > file. >Therefore, it partly addresses https://bugs.openjdk.org/browse/JDK-8292316, >in order to unblock the "Update to use jtreg 7" PR 9393: >https://github.com/openjdk/jdk/pull/9393 > - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 > - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 > - ... and 4 more: https://git.openjdk.org/jdk/compare/3464019d...16b140ab Is jtreg 7 downward compatible? Can I use it to test older JDKs, if yes, down to which version? Thanks! - PR: https://git.openjdk.org/jdk/pull/9393
Re: RFR: JDK-8289798: Update to use jtreg 7 [v6]
> Please review the change to update to using jtreg 7. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion` has been updated in the various `TEST.ROOT` > files. Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Update configure to check for jtreg 7 or later - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Revert junit.java Commit https://github.com/openjdk/jdk/commit/45c3e898ed538545921395372fe507e9111401e1 deleted this file - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Update to new JUnit JAR file With version 7 of `jtreg` comes JUnit Platform 1.8.2 (also known as "JUnit 5.8.2"). This change updates the hard-coded library tag value to the new JUnit JAR file. Therefore, it partly addresses https://bugs.openjdk.org/browse/JDK-8292316, in order to unblock the "Update to use jtreg 7" PR 9393: https://github.com/openjdk/jdk/pull/9393 - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - ... and 4 more: https://git.openjdk.org/jdk/compare/3464019d...16b140ab - Changes: https://git.openjdk.org/jdk/pull/9393/files Webrev: https://webrevs.openjdk.org/?repo=jdk=9393=05 Stats: 11 lines in 8 files changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk/pull/9393.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9393/head:pull/9393 PR: https://git.openjdk.org/jdk/pull/9393
