Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java > javax/crypto/CryptoPermissions/InconsistentEntries.java Bill Huang has updated the pull request incrementally with one additional commit since the last revision: AssertThrows an exception in InconsistentEntries test. - Changes: - all: https://git.openjdk.org/jdk/pull/10637/files - new: https://git.openjdk.org/jdk/pull/10637/files/4911518e..cfb9f74d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10637&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10637&range=01-02 Stats: 9 lines in 1 file changed: 1 ins; 6 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/10637.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10637/head:pull/10637 PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java >> javax/crypto/CryptoPermissions/InconsistentEntries.java > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > AssertThrows an exception in InconsistentEntries test. test/jdk/javax/crypto/CryptoPermissions/default_local.policy line 4: > 2: permission javax.crypto.CryptoAllPermission; > 3: permission javax.crypto.CryptoPermission "DES", 64; > 4: } please remove extra line. test/jdk/sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java line 46: > 44: * @summary standard extensions path is hard-coded in default > 45: * system policy file > 46: * No need to repeat these statement again. test/jdk/sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java line 54: > 52: * @bug 4993819 > 53: * @summary standard extensions path is hard-coded in default > 54: * system policy file No need to repeat these statement. - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java >> javax/crypto/CryptoPermissions/InconsistentEntries.java > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > AssertThrows an exception in InconsistentEntries test. Looks good to me. Please update few formatting related comments. - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
On Tue, 18 Oct 2022 19:53:50 GMT, Mahendra Chhipa wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AssertThrows an exception in InconsistentEntries test. > > test/jdk/javax/crypto/CryptoPermissions/default_local.policy line 4: > >> 2: permission javax.crypto.CryptoAllPermission; >> 3: permission javax.crypto.CryptoPermission "DES", 64; >> 4: } > > please remove extra line. I double-checked, there is no extra line at the end of this file. > test/jdk/sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java line 46: > >> 44: * @summary standard extensions path is hard-coded in default >> 45: * system policy file >> 46: * > > No need to repeat these statement again. Are you saying that we don't need to run the ExtDir2.policy and ExtDir3.policy? - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java >> javax/crypto/CryptoPermissions/InconsistentEntries.java > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > AssertThrows an exception in InconsistentEntries test. Looks good to me. - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
On Tue, 18 Oct 2022 22:11:57 GMT, Bill Huang wrote: >> test/jdk/javax/crypto/CryptoPermissions/default_local.policy line 4: >> >>> 2: permission javax.crypto.CryptoAllPermission; >>> 3: permission javax.crypto.CryptoPermission "DES", 64; >>> 4: } >> >> please remove extra line. > > I double-checked, there is no extra line at the end of this file. Ok >> test/jdk/sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java line >> 46: >> >>> 44: * @summary standard extensions path is hard-coded in default >>> 45: * system policy file >>> 46: * >> >> No need to repeat these statement again. > > Are you saying that we don't need to run the ExtDir2.policy and > ExtDir3.policy? Its fine, ignore my previous comment. - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
On Wed, 19 Oct 2022 16:49:33 GMT, Mahendra Chhipa wrote: >> Are you saying that we don't need to run the ExtDir2.policy and >> ExtDir3.policy? > > Its fine, ignore my previous comment. you can add multiple run tags under same test tag, no need to repeat tag, bug, and summary tags. - PR: https://git.openjdk.org/jdk/pull/10637
