Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]
On Fri, 13 Jan 2023 22:54:47 GMT, Joe Darcy wrote: >> With generalized see and link tags that can refer to anchors (JDK-8200337), >> the see and link tags in core libraries should be updated to use this >> feature when possible. This PR covers such updates for java.base. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typo found in code review. Changes in collections look good. I think there are a bunch of other places where this could be used, but fixing up optional-restrictions is a good start. - Marked as reviewed by smarks (Reviewer). PR: https://git.openjdk.org/jdk/pull/12000
Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]
On Mon, 16 Jan 2023 15:06:25 GMT, Daniel Fuchs wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo found in code review.
>
> src/java.base/share/classes/java/lang/CharSequence.java line 76:
>
>> 74: *
>> 75: * If the {@code char} value specified by the index is a
>> 76: * {@linkplain Character##unicode surrogate}, the surrogate value
>
> I didn't know about the `##` trick. Is that a new feature to target an HTML
> anchor?
The CSR has a concise description:
[JDK-8294195](https://bugs.openjdk.org/browse/JDK-8294195) Generalize see and
link tags for user-defined anchors
-
PR: https://git.openjdk.org/jdk/pull/12000
Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]
On Fri, 13 Jan 2023 22:54:47 GMT, Joe Darcy wrote: >> With generalized see and link tags that can refer to anchors (JDK-8200337), >> the see and link tags in core libraries should be updated to use this >> feature when possible. This PR covers such updates for java.base. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typo found in code review. Changes to InetAddressResolverProvider.java look good. - PR: https://git.openjdk.org/jdk/pull/12000
Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]
On Fri, 13 Jan 2023 22:54:47 GMT, Joe Darcy wrote:
>> With generalized see and link tags that can refer to anchors (JDK-8200337),
>> the see and link tags in core libraries should be updated to use this
>> feature when possible. This PR covers such updates for java.base.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo found in code review.
src/java.base/share/classes/java/lang/CharSequence.java line 76:
> 74: *
> 75: * If the {@code char} value specified by the index is a
> 76: * {@linkplain Character##unicode surrogate}, the surrogate value
I didn't know about the `##` trick. Is that a new feature to target an HTML
anchor?
-
PR: https://git.openjdk.org/jdk/pull/12000
Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]
On Fri, 13 Jan 2023 22:38:32 GMT, Naoto Sato wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo found in code review.
>
> src/java.base/share/classes/java/util/ResourceBundle.java line 270:
>
>> 268: * are packaged in a JAR file. Resource bundle only JAR file can be
>> readily
>> 269: * deployed as an {@linkplain
>> java.lang.module.ModuleFinder##automatic-modules
>> 270: * automatic module1}. For example, if the JAR file contains the
>
> Typo: extra `1`
Doh! Thanks; fixed in next push.
-
PR: https://git.openjdk.org/jdk/pull/12000
Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]
On Fri, 13 Jan 2023 22:50:53 GMT, Joe Darcy wrote: >> With generalized see and link tags that can refer to anchors (JDK-8200337), >> the see and link tags in core libraries should be updated to use this >> feature when possible. This PR covers such updates for java.base. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typo found in code review. Changes in `ResoruceBundle` look good. - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.org/jdk/pull/12000
Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]
On Fri, 13 Jan 2023 22:50:53 GMT, Joe Darcy wrote: >> With generalized see and link tags that can refer to anchors (JDK-8200337), >> the see and link tags in core libraries should be updated to use this >> feature when possible. This PR covers such updates for java.base. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typo found in code review. Marked as reviewed by mchung (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12000
Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]
> With generalized see and link tags that can refer to anchors (JDK-8200337), > the see and link tags in core libraries should be updated to use this feature > when possible. This PR covers such updates for java.base. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Fix typo found in code review. - Changes: - all: https://git.openjdk.org/jdk/pull/12000/files - new: https://git.openjdk.org/jdk/pull/12000/files/aa623f2a..0e4d4e4b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=12000=01 - incr: https://webrevs.openjdk.org/?repo=jdk=12000=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/12000.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12000/head:pull/12000 PR: https://git.openjdk.org/jdk/pull/12000
Re: RFR: JDK-8300133: Use generalized see and link tags in core libs
On Fri, 13 Jan 2023 21:30:06 GMT, Joe Darcy wrote:
> With generalized see and link tags that can refer to anchors (JDK-8200337),
> the see and link tags in core libraries should be updated to use this feature
> when possible. This PR covers such updates for java.base.
src/java.base/share/classes/java/util/ResourceBundle.java line 270:
> 268: * are packaged in a JAR file. Resource bundle only JAR file can be
> readily
> 269: * deployed as an {@linkplain
> java.lang.module.ModuleFinder##automatic-modules
> 270: * automatic module1}. For example, if the JAR file contains the
typo : `module1`?
-
PR: https://git.openjdk.org/jdk/pull/12000
Re: RFR: JDK-8300133: Use generalized see and link tags in core libs
On Fri, 13 Jan 2023 21:30:06 GMT, Joe Darcy wrote:
> With generalized see and link tags that can refer to anchors (JDK-8200337),
> the see and link tags in core libraries should be updated to use this feature
> when possible. This PR covers such updates for java.base.
src/java.base/share/classes/java/util/ResourceBundle.java line 270:
> 268: * are packaged in a JAR file. Resource bundle only JAR file can be
> readily
> 269: * deployed as an {@linkplain
> java.lang.module.ModuleFinder##automatic-modules
> 270: * automatic module1}. For example, if the JAR file contains the
Typo: extra `1`
-
PR: https://git.openjdk.org/jdk/pull/12000
Re: RFR: JDK-8300133: Use generalized see and link tags in core libs
On Fri, 13 Jan 2023 21:30:06 GMT, Joe Darcy wrote: > With generalized see and link tags that can refer to anchors (JDK-8200337), > the see and link tags in core libraries should be updated to use this feature > when possible. This PR covers such updates for java.base. Nice to see all those `https://git.openjdk.org/jdk/pull/12000
