Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > remove added blank lines Thanks for the reviews ! - PR Comment: https://git.openjdk.org/jdk/pull/15916#issuecomment-1736794264
Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > remove added blank lines Marked as reviewed by almatvee (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15916#pullrequestreview-1645006874
Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > remove added blank lines Marked as reviewed by m4ximumpi...@github.com (no known OpenJDK username). - PR Review: https://git.openjdk.org/jdk/pull/15916#pullrequestreview-1644929303
Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > remove added blank lines Marked as reviewed by asemenyuk (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15916#pullrequestreview-1644318101
Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > remove added blank lines Looks good to me. - Marked as reviewed by cstein (Committer). PR Review: https://git.openjdk.org/jdk/pull/15916#pullrequestreview-1644317352
Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > remove added blank lines Thank you Matthias for the update and testing the change. The change looks fine to me, but I'll let someone more familiar with these jpackage tests to officially review this. - PR Comment: https://git.openjdk.org/jdk/pull/15916#issuecomment-1735472237
Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]
> AIX currently does not have the jdk.jpackage system module. We have to take > this into account for these jpackage tests. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: remove added blank lines - Changes: - all: https://git.openjdk.org/jdk/pull/15916/files - new: https://git.openjdk.org/jdk/pull/15916/files/2e6f1713..eca268f4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=15916=02 - incr: https://webrevs.openjdk.org/?repo=jdk=15916=01-02 Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/15916.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15916/head:pull/15916 PR: https://git.openjdk.org/jdk/pull/15916
