Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]
On Thu, 1 Feb 2024 22:19:26 GMT, Joe Darcy wrote: >> The restricted javac warning is disabled for java.base, but could be enabled >> by suppressing the warning in a handful of files. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Add comment highlighting restricted method calls. Great, thanks for cleaning up! - Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17677#pullrequestreview-1859561572
Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]
On Thu, 1 Feb 2024 22:19:26 GMT, Joe Darcy wrote: >> The restricted javac warning is disabled for java.base, but could be enabled >> by suppressing the warning in a handful of files. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Add comment highlighting restricted method calls. Nice fix. Thanks. - Marked as reviewed by pminborg (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17677#pullrequestreview-1858547285
Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]
On Thu, 1 Feb 2024 22:19:26 GMT, Joe Darcy wrote: >> The restricted javac warning is disabled for java.base, but could be enabled >> by suppressing the warning in a handful of files. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Add comment highlighting restricted method calls. Looks good - a pity that we cannot disable the warning at the package level - I think it would make sense give blanket approval to the FFM implementation classes. But, even like this it's not too bad. Thanks. - Marked as reviewed by mcimadamore (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17677#pullrequestreview-1858347672
Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]
On Thu, 1 Feb 2024 22:01:49 GMT, Jorn Vernee wrote: > This looks good to me. It will be easier to find where we are doing > restricted operations like this. Right; follows the recommended approach of minimizing the scope of the SuppressWarnings annotations too. Thanks. - PR Comment: https://git.openjdk.org/jdk/pull/17677#issuecomment-1922360484
Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]
> The restricted javac warning is disabled for java.base, but could be enabled > by suppressing the warning in a handful of files. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Add comment highlighting restricted method calls. - Changes: - all: https://git.openjdk.org/jdk/pull/17677/files - new: https://git.openjdk.org/jdk/pull/17677/files/4973b1fb..9ac261c0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17677=01 - incr: https://webrevs.openjdk.org/?repo=jdk=17677=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/17677.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17677/head:pull/17677 PR: https://git.openjdk.org/jdk/pull/17677
