Re: [coreboot] Is there anything I can do to make coreboot better?
Dear Shawn, Am Donnerstag, den 19.05.2011, 03:45 + schrieb shawn Bai: Hello, guys, … and girls. I am very pleased to have the chance to talk with you. I hope I do not bother you. My name is Shawn Bai, and you can call me Shawn, it's OK. Welcome. I am very interested both in the low-level in embedded system, and in BIOS level in desktop computer or server. I get to know this open source project while I browse the internet. I think it's a very good project to help me understand what happens within the system, even more. Is there anything I can do to make coreboot better? I have some work experience in embedded system low-level development, mainly in Board support package. Hope to hear from you soon. You could look into the issue raised in the other thread and try to unify `acpi_table.c` [1]. Some more random notes. 1. To handle patches more easily¹ you can also use Git [2]. 2. Please just send plain text messages to the list [3]. 3. Another way to contact or talk to the developers is the IRC channel [4]. I am looking forward to your contributions, Paul ¹ At least Sven told at the LinuxTag that handling patches with SVN/Subversion and no commit access is a real pain. [1] http://www.coreboot.org/pipermail/coreboot/2011-May/065184.html [2] http://www.coreboot.org/Git [3] http://www.asciiribbon.org/ [4] http://www.coreboot.org/IRC signature.asc Description: This is a digitally signed message part -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] Is there anything I can do to make coreboot better?
Dear Paul, As the beginning, the source code is needed to be download,After that, I will look into the thread you have mentioned, it's an entry point for me to go with coreboot, though I am not very familiar with ACPI.but the interest is best teacher, isn't it?I will do it step by step. Thanks for your advice. -- Message: 8 Date: Thu, 19 May 2011 08:37:53 +0200 From: Paul Menzel paulepan...@users.sourceforge.net To: coreboot@coreboot.org Subject: Re: [coreboot] Is there anything I can do to make coreboot better? Message-ID: 1305787073.4377.7.camel@mattotaupa Content-Type: text/plain; charset=utf-8 Dear Shawn, Am Donnerstag, den 19.05.2011, 03:45 + schrieb shawn Bai: Hello, guys, ? and girls. I am very pleased to have the chance to talk with you. I hope I do not bother you. My name is Shawn Bai, and you can call me Shawn, it's OK. Welcome. I am very interested both in the low-level in embedded system, and in BIOS level in desktop computer or server. I get to know this open source project while I browse the internet. I think it's a very good project to help me understand what happens within the system, even more. Is there anything I can do to make coreboot better? I have some work experience in embedded system low-level development, mainly in Board support package. Hope to hear from you soon. You could look into the issue raised in the other thread and try to unify `acpi_table.c` [1]. Some more random notes. 1. To handle patches more easily? you can also use Git [2]. 2. Please just send plain text messages to the list [3]. 3. Another way to contact or talk to the developers is the IRC channel [4]. I am looking forward to your contributions, Paul ? At least Sven told at the LinuxTag that handling patches with SVN/Subversion and no commit access is a real pain. [1] http://www.coreboot.org/pipermail/coreboot/2011-May/065184.html [2] http://www.coreboot.org/Git [3] http://www.asciiribbon.org/ [4] http://www.coreboot.org/IRC -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part URL: http://www.coreboot.org/pipermail/coreboot/attachments/20110519/a9a1ceed/attachment-0001.sig -- ___ coreboot mailing list coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot End of coreboot Digest, Vol 75, Issue 56 -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
[coreboot] [commit] r6600 - in trunk/src/mainboard/amd: bimini_fam10 dbm690t inagua mahogany mahogany_fam10 persimmon pistachio serengeti_cheetah serengeti_cheetah_fam10 tilapia_fam10
Author: Sduplichan Date: Fri May 20 02:06:09 2011 New Revision: 6600 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6600 Log: Move the ACPI FACP table to the front of the RSDT list. This is done to work around a Windows XP or Server 2003 setup failure where an error message such as: An unexpected error (805262864) occurred at line 1768 of d:\xpclient\base\boot\setup\arcdisp.c occurs. This change updates AMD reference board projects, but could applied to others as well. Signed-off-by: Scott Duplichan sc...@notabs.org Acked-by: Marc Jones marcj...@gmail.com Modified: trunk/src/mainboard/amd/bimini_fam10/acpi_tables.c trunk/src/mainboard/amd/dbm690t/acpi_tables.c trunk/src/mainboard/amd/inagua/acpi_tables.c trunk/src/mainboard/amd/mahogany/acpi_tables.c trunk/src/mainboard/amd/mahogany_fam10/acpi_tables.c trunk/src/mainboard/amd/persimmon/acpi_tables.c trunk/src/mainboard/amd/pistachio/acpi_tables.c trunk/src/mainboard/amd/serengeti_cheetah/acpi_tables.c trunk/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c trunk/src/mainboard/amd/tilapia_fam10/acpi_tables.c Modified: trunk/src/mainboard/amd/bimini_fam10/acpi_tables.c == --- trunk/src/mainboard/amd/bimini_fam10/acpi_tables.c Mon May 16 17:32:28 2011(r6599) +++ trunk/src/mainboard/amd/bimini_fam10/acpi_tables.c Fri May 20 02:06:09 2011(r6600) @@ -127,6 +127,31 @@ acpi_write_rsdp(rsdp, rsdt, NULL); acpi_write_rsdt(rsdt); + /* DSDT */ + current = ( current + 0x07) -0x08; + printk(BIOS_DEBUG, ACPI:* DSDT at %lx\n, current); + dsdt = (acpi_header_t *)current; // it will used by fadt + memcpy(dsdt, AmlCode, sizeof(acpi_header_t)); + current += dsdt-length; + memcpy(dsdt, AmlCode, dsdt-length); + printk(BIOS_DEBUG, ACPI:* DSDT @ %p Length %x\n,dsdt,dsdt-length); + + /* FACS */ // it needs 64 bit alignment + current = ( current + 0x07) -0x08; + printk(BIOS_DEBUG, ACPI: * FACS at %lx\n, current); + facs = (acpi_facs_t *) current; // it will be used by fadt + current += sizeof(acpi_facs_t); + acpi_create_facs(facs); + + /* FADT */ + current = ( current + 0x07) -0x08; + printk(BIOS_DEBUG, ACPI:* FADT at %lx\n, current); + fadt = (acpi_fadt_t *) current; + current += sizeof(acpi_fadt_t); + + acpi_create_fadt(fadt, facs, dsdt); + acpi_add_table(rsdp, fadt); + /* * We explicitly add these tables later on: */ @@ -219,31 +244,6 @@ } #endif - /* DSDT */ - current = ( current + 0x07) -0x08; - printk(BIOS_DEBUG, ACPI:* DSDT at %lx\n, current); - dsdt = (acpi_header_t *)current; // it will used by fadt - memcpy(dsdt, AmlCode, sizeof(acpi_header_t)); - current += dsdt-length; - memcpy(dsdt, AmlCode, dsdt-length); - printk(BIOS_DEBUG, ACPI:* DSDT @ %p Length %x\n,dsdt,dsdt-length); - - /* FACS */ // it needs 64 bit alignment - current = ( current + 0x07) -0x08; - printk(BIOS_DEBUG, ACPI: * FACS at %lx\n, current); - facs = (acpi_facs_t *) current; // it will be used by fadt - current += sizeof(acpi_facs_t); - acpi_create_facs(facs); - - /* FADT */ - current = ( current + 0x07) -0x08; - printk(BIOS_DEBUG, ACPI:* FADT at %lx\n, current); - fadt = (acpi_fadt_t *) current; - current += sizeof(acpi_fadt_t); - - acpi_create_fadt(fadt, facs, dsdt); - acpi_add_table(rsdp, fadt); - #if DUMP_ACPI_TABLES == 1 printk(BIOS_DEBUG, rsdp\n); dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t)); Modified: trunk/src/mainboard/amd/dbm690t/acpi_tables.c == --- trunk/src/mainboard/amd/dbm690t/acpi_tables.c Mon May 16 17:32:28 2011(r6599) +++ trunk/src/mainboard/amd/dbm690t/acpi_tables.c Fri May 20 02:06:09 2011(r6600) @@ -129,6 +129,27 @@ acpi_write_rsdp(rsdp, rsdt, NULL); acpi_write_rsdt(rsdt); + /* FACS */ + printk(BIOS_DEBUG, ACPI:* FACS\n); + facs = (acpi_facs_t *) current; + current += sizeof(acpi_facs_t); + acpi_create_facs(facs); + + /* DSDT */ + printk(BIOS_DEBUG, ACPI:* DSDT\n); + dsdt = (acpi_header_t *)current; + memcpy(dsdt, AmlCode, sizeof(acpi_header_t)); + current += dsdt-length; + memcpy(dsdt, AmlCode, dsdt-length); + printk(BIOS_DEBUG, ACPI:* DSDT @ %p Length %x\n, dsdt, dsdt-length); + /* FADT */ + printk(BIOS_DEBUG, ACPI:* FADT\n); + fadt = (acpi_fadt_t *) current; + current += sizeof(acpi_fadt_t); + + acpi_create_fadt(fadt, facs, dsdt); + acpi_add_table(rsdp, fadt); + /* * We explicitly add these
Re: [coreboot] [PATCH] workaround for An unexpected error (805262864) occurred at line 1768 of d:\xpclient\base\boot\setup\arcdisp.c
Marc Jones wrote: The attached patch works around a Windows XP or Server 2003 setup failure where an error message such as: An unexpected error (805262864) occurred at line 1768 of d:\xpclient\base\boot\setup\arcdisp.c The value 805262864 varies, and is the physical address, in decimal, of one of the ACPI tables. Tested on Persimmon. Others abuild tested only. Signed-off-by: Scott Duplichan sc...@notabs.org ]It looks like src/mainboard/amd/mahogany/acpi_tables.c has a double ]paste issue. Fix that and it looks good. ] ]Acked-by: Marc Jones marcj...@gmail.com ] ] ]Marc Hello Marc, Thanks for finding the double paste problem in mahogany. This change is revision 6600. Thanks, Scott -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
