Re: [coreboot] gerrit changes: Forge author behaviour
Patrick Georgi wrote: > So we now have a new column in gerrit, "AMR" for "Author-Must-Review" .. > Because of this, the feature allows to add teams, where people can > publish changes for each others without the new requirement. These are two great improvements for our workflow! Thanks a lot for implementing this Patrick. //Peter pgpVY6vnzwNcO.pgp Description: PGP signature -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
[coreboot] coreboot accepted to GSoC 2014
Hi, coreboot has been accepted to this year's GSoC. Students can apply with projects between March 10th and March 21st, but of course it helps to prepare a project proposal early and with feedback from coreboot developers. If you know someone who's eligible (higher education student) and has interest in firmware development, please pass this on. If you're interested yourself, all the better: you've already subscribed to the right list. More information can be found on GSoC's platform "Melange", https://google-melange.appspot.com/gsoc/org2/google/gsoc2014/coreboot Project ideas can be discussed here, or on IRC: http://www.coreboot.org/IRC Regards, Patrick Georgi signature.asc Description: This is a digitally signed message part -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] Unable to start correctly coreboot on Asus f2a85-m REV 1.02
HacKurx [mailto:hack...@gmail.com] wrote: ]Thank you for adding this great feature that I hope will be added by ]default in Kconfig. ]Unfortunately, this option has no more help me to solve my problem ]with the richland architecture. Your board is probably crashing at line 252 of file: vendorcode/amd/agesa/f15tn/Proc/CPU/cpuFamilyTranslation.c SubFamilyIdPtr[j] ((CONST CPU_LOGICAL_ID_XLAT **)&CpuLogicalIdAndRevPtr, &LogicalIdEntries, &LogicalFamily, StdHeader); The reason is that the loop is processing each element of table F15LogicalIdTable until a match is found. But that table includes a NULL terminator (line 1176 of file: vendorcode/amd/agesa/f15tn/Include/ OptionFamily15hInstall.h) This means that if no CPUID match is found, a NULL function pointer will be called. That problem is an agesa bug that shows up only when an unsupported cpu is found. The cupid is not found because trinity support is included but richland support is needed. I do not know if forcing the trinity code to run on richland will work, but you could try it. One way to try it is to change the == to != on line 255 of file vendorcode/amd/agesa/f15tn/Proc/CPU/cpuFamilyTranslation.c. Thanks, Scott -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
[coreboot] gerrit changes: Forge author behaviour
Hi, I extended our gerrit installation to support "forge author" safely. Forge author is the capability to push changes with an author field different from your own. This is useful when sending patches you've got from someone else while preserving attribution. One downside of this capability, due to which we disabled it for a while, is that it's possible for a change to go through gerrit without the original author noticing. Maybe the author had issues with the change because it was still unfinished - but good enough for others. This is what happened for us. So we now have a new column in gerrit, "AMR" for "Author-Must-Review" that's active if a change is sent with different author and committer fields. Under the new policy, the original author must review the change positively (meaning +1 or +2) before submission is allowed. Of course, the usual rules (Verified +1, Code-Review +2) still apply. There is one notable exception: Since there are some large upstreaming efforts every now and then (mostly by Google), this rule is inconvenient and counter-productive there. We can assume that within such groups, people allow their "designated upstreamer" to push changes for them. Because of this, the feature allows to add teams, where people can publish changes for each others without the new requirement. If you have such needs, please tell me about your team and I'll set it up. This is in testing mode - if you find any weird behaviour or you run into walls because of this change, please tell me. If that model doesn't work out, we'll revert it. But for now, these are the rules. Regards, Patrick signature.asc Description: This is a digitally signed message part -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
