[coreboot] Re: ACPI_BIOS_ERROR windows boot error with PCIe GPU

2019-06-14 Thread Patrick Georgi via coreboot
Alex Feinman  schrieb am Fr., 14. Juni 2019, 08:46:

> When BSOD hits, you will see 4 hex values - BSOD parameters. For A5
> (ACPI_BIOS_ERROR) they can be decoded using this table:
>
> https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/bug-check-0xa5--acpi-bios-error
>
> This list is not complete and I have a standing bug report to fix that.

Please do. I collected a few additional conditions at www.coreboot.org/ACPI
but it's better to have them all in a single location.


Patrick
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org


[coreboot] Re: coreboot - toshiba laptop

2019-06-14 Thread awokd via coreboot

miel...@t-online.de:

Toshiba Tecra S4
Model No. PTS40E-01K00JGR
SERIAL No. 27056280H

Dear ladies and gentlemen,

I could compile coreboot. A test with qemu, as described in coreboot - 
lesson 1
was successful. But this configuration with mainboard = emulation is for 
demon-
stration only, isn't it ? I did not find the toshiba mainboard. If it is 
possible, please
give me some tips, how I can continue, because for me this is untouched 
land.
Because of the fact, that this is an old laptop with many security 
elements and a

separate password chip, would you say, let it be ?


Yes, qemu coreboot is just for emulation. It can be used for debugging 
and booting VMs. I don't see any Toshiba mainboards on 
https://review.coreboot.org/plugins/gitiles/board-status/+/refs/heads/master. 
You can try looking in older versions of the source code. I don't think 
the board status list includes all older versions.

___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org


[coreboot] New Defects reported by Coverity Scan for coreboot

2019-06-14 Thread scan-admin
Hi,

Please find the latest report on new defect(s) introduced to coreboot found 
with Coverity Scan.

1 new defect(s) introduced to coreboot found with Coverity Scan.
356 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1401935:  Error handling issues  (CHECKED_RETURN)
/3rdparty/vboot/futility/updater.c: 1785 in save_from_stdin()



*** CID 1401935:  Error handling issues  (CHECKED_RETURN)
/3rdparty/vboot/futility/updater.c: 1785 in save_from_stdin()
1779assert(in);
1780if (!out)
1781return -1;
1782 
1783while (!feof(in)) {
1784sz = fread(buffer, 1, sizeof(buffer), in);
>>> CID 1401935:  Error handling issues  (CHECKED_RETURN)
>>> Calling "fwrite" without checking return value (as is done elsewhere 23 
>>> out of 28 times).
1785fwrite(buffer, 1, sz, out);
1786}
1787fclose(out);
1788return 0;
1789 }
1790 



To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvaU4HClancRgJSp1vcdHRWU-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bbrs-2BX6ZS8Qa21NneyN4LIzx13VEWZ80L2Ouuf1gIjjG2NLWLHI8Xlm-2BHoz1LIkoopp-2FIQgdCPB7DWOzcqgz7mwEcf3JSe86im3z7TkwS0AOkQcvwcVXm9dNGz1oZTCf6t2Ze03mywDH-2FeNhYtM5bOM-2BUp9l9gpcsTrftLA-2FTAFj9M3Ho0D-2FFROeA86C8OlF8-3D
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org


[coreboot] compiler/toolchain issue?

2019-06-14 Thread mturney



A quick look on the mailing list doesn't show this issue for anybody 
else so I have to assume something with my setup.
For past year + I have been working with coreboot in Chromium chroot 
environment.
Yesterday I had to go back to the standalone build environment.  This is 
happening from tip of upstream master.
It is consistent with i386, arm and aarch64 toolchain.  This output is 
following Lesson 1 so it is from i386 with QEMU configuration.


Using git blame, all of the code (cbfstool & commonlib headers) was last 
modified 2015 and 2017, so figure it is toolchain and/or my host, which 
is Ubuntu 16.04.



I will add that there is an issue with chrome-ec repo access, but doubt 
that is contributory to this build error, but here are the messages from 
chrome-ec first:


  Cloning into '3rdparty/chromeec'...
  X11 forwarding request failed on channel 0
  fatal: Project not found: coreboot/chrome-ec
  fatal: Could not read from remote repository.

  Please make sure you have the correct access rights
  and the repository exists.
  Clone of 
'ssh://review-android.quicinc.com:29418/coreboot/chrome-ec.git' into 
submodule path '3rdparty/chromeec' failed



And here is tail-end of coreboot build that fails:

CC postcar/southbridge/intel/common/reset.o
CC postcar/southbridge/intel/common/rtc.o
LINK   cbfs/fallback/postcar.debug
IASL   build/dsdt.aml

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20190509
Copyright (c) 2000 - 2019 Intel Corporation

coreboot toolchain vc15e600 2019-05-10
ASL Input: dsdt.asl -   15113 bytes245 keywords399 source 
lines
AML Output:dsdt.aml -4021 bytes 99 opcodes 146 named 
objects


Compilation successful. 0 Errors, 0 Warnings, 0 Remarks, 234 
Optimizations

IASL   build/dsdt.aml disassembled correctly.
HOSTCC cbfstool/cbfstool.o
In file included from :0:0:
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/util/cbfstool/cbfstool.c: 
In function 'cbfs_add_component':
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/compiler.h:59:2: 
error: first argument to '__builtin_choose_expr' not a constant
  __builtin_choose_expr(__builtin_constant_p(expr), fallback_expr, 
expr))

  ^
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:39:2: 
note: in expansion of macro '__TYPEOF_UNLESS_CONST'

  __TYPEOF_UNLESS_CONST(a, b) var_a = (a); \
  ^
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:49:26: 
note: in expansion of macro '__CMP_SAFE'

  __CMP_UNSAFE(a, b, op), __CMP_SAFE(a, b, op, __TMPNAME, __TMPNAME))
  ^
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:56:19: 
note: in expansion of macro '__CMP'

 #define MAX(a, b) __CMP(a, b, >)
   ^
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/util/cbfstool/cbfstool.c:546:19: 
note: in expansion of macro 'MAX'

   uint32_t size = MAX(hs, param.padding);
   ^
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/compiler.h:59:2: 
error: first argument to '__builtin_choose_expr' not a constant
  __builtin_choose_expr(__builtin_constant_p(expr), fallback_expr, 
expr))

  ^
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:40:2: 
note: in expansion of macro '__TYPEOF_UNLESS_CONST'

  __TYPEOF_UNLESS_CONST(b, a) var_b = (b); \
  ^
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:49:26: 
note: in expansion of macro '__CMP_SAFE'

  __CMP_UNSAFE(a, b, op), __CMP_SAFE(a, b, op, __TMPNAME, __TMPNAME))
  ^
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:56:19: 
note: in expansion of macro '__CMP'

 #define MAX(a, b) __CMP(a, b, >)
   ^
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/util/cbfstool/cbfstool.c:546:19: 
note: in expansion of macro 'MAX'

   uint32_t size = MAX(hs, param.padding);
   ^
In file included from 
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/util/cbfstool/common.h:25:0,
 from 
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/util/cbfstool/cbfstool.c:26:
/local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:47

[coreboot] Re: compiler/toolchain issue?

2019-06-14 Thread Patrick Georgi via coreboot
Hey Mike,

 schrieb am Fr., 14. Juni 2019, 22:12:

>
>Please make sure you have the correct access rights
>and the repository exists.
>Clone of
> 'ssh://review-android.quicinc.com:29418/coreboot/chrome-ec.git' into
> submodule path '3rdparty/chromeec' failed
>
These are because we use relative paths for the submodules. The idea is
that mirrors also mirror the submodules and everything is then loaded from
the same location.

Chrome EC should be no problem, but coreboot relies on the vboot submodule
these days which is imported the same way.

And here is tail-end of coreboot build that fails:


  HOSTCC cbfstool/cbfstool.o
> In file included from :0:0:
> /local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/util/cbfstool/cbfstool.c:
>
> In function 'cbfs_add_component':
> /local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/compiler.h:59:2:
>
> error: first argument to '__builtin_choose_expr' not a constant
>__builtin_choose_expr(__builtin_constant_p(expr), fallback_expr,
> expr))
>^
> /local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:39:2:
>
> note: in expansion of macro '__TYPEOF_UNLESS_CONST'
>__TYPEOF_UNLESS_CONST(a, b) var_a = (a); \
>^
> /local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:49:26:
>
> note: in expansion of macro '__CMP_SAFE'
>__CMP_UNSAFE(a, b, op), __CMP_SAFE(a, b, op, __TMPNAME, __TMPNAME))
>^
> /local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/src/commonlib/include/commonlib/helpers.h:56:19:
>
> note: in expansion of macro '__CMP'
>   #define MAX(a, b) __CMP(a, b, >)
> ^
> /local/mnt/workspace/mturney/gitrepos/qualcomm/chromebook/cbdc-meta/standalone/coreboot/util/cbfstool/cbfstool.c:546:19:
>
> note: in expansion of macro 'MAX'
> uint32_t size = MAX(hs, param.padding);
>
This is built with your host compiler. Probably an old compiler?


Patrick
___
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org