Re: [coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
Am 03.05.2011 20:11, schrieb Stefan Reinauer: > On 03.05.2011, at 11:01, Patrick Georgi wrote: >> We also need to push data from build system variables into romcc (ie. >> -DA=B flags) for bootblock. Not impossible, but not as automatic as it >> currently works. > Can't we just call the bootblock compilation with -include > path/to/component/bootblock.c ? Feasible, with some additional plumbing Patrick -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
On 03.05.2011, at 11:01, Patrick Georgi wrote: > Am 03.05.2011 18:10, schrieb Stefan Reinauer: >> I agree this belongs in the Makefiles.. Not sure why we chose to put it here >> but it might have required another makefile pass otherwise > "Back then" the build system was a bit limited, so this was more feasible. > > We also need to push data from build system variables into romcc (ie. > -DA=B flags) for bootblock. Not impossible, but not as automatic as it > currently works. > > Can't we just call the bootblock compilation with -include path/to/component/bootblock.c ? > Patrick > > -- > coreboot mailing list: coreboot@coreboot.org > http://www.coreboot.org/mailman/listinfo/coreboot > -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
Am 03.05.2011 18:10, schrieb Stefan Reinauer: > I agree this belongs in the Makefiles.. Not sure why we chose to put it here > but it might have required another makefile pass otherwise "Back then" the build system was a bit limited, so this was more feasible. We also need to push data from build system variables into romcc (ie. -DA=B flags) for bootblock. Not impossible, but not as automatic as it currently works. Patrick -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
On 03.05.2011, at 06:04, Peter Stuge wrote: > repository service wrote: >> +++ trunk/src/southbridge/intel/i82801gx/KconfigTue May 3 09:55:30 2011 >>(r6553) >> @@ -38,5 +38,10 @@ >>int >>default 1 >> >> +config BOOTBLOCK_SOUTHBRIDGE_INIT >> +string >> +default "southbridge/intel/i82801gx/bootblock.c" >> +depends on SOUTHBRIDGE_INTEL_I82801GX >> + > > Why in Kconfig and not a Makefile variable? > > Oh and please always double-check the whitespace. (See "string") > > > //Peter I agree this belongs in the Makefiles.. Not sure why we chose to put it here but it might have required another makefile pass otherwise -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
Peter Stuge writes: > repository service wrote: >> +++ trunk/src/southbridge/intel/i82801gx/Kconfig Tue May 3 09:55:30 >> 2011(r6553) >> @@ -38,5 +38,10 @@ >> int >> default 1 >> >> +config BOOTBLOCK_SOUTHBRIDGE_INIT >> +string >> +default "southbridge/intel/i82801gx/bootblock.c" >> +depends on SOUTHBRIDGE_INTEL_I82801GX >> + > > Why in Kconfig and not a Makefile variable? That's how the current implementation wants it. Changing that is beyond the scope of that Patch. Sorry for the whitespace error. Sven. -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
repository service wrote: > +++ trunk/src/southbridge/intel/i82801gx/Kconfig Tue May 3 09:55:30 > 2011(r6553) > @@ -38,5 +38,10 @@ > int > default 1 > > +config BOOTBLOCK_SOUTHBRIDGE_INIT > +string > + default "southbridge/intel/i82801gx/bootblock.c" > + depends on SOUTHBRIDGE_INTEL_I82801GX > + Why in Kconfig and not a Makefile variable? Oh and please always double-check the whitespace. (See "string") //Peter -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
[coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
Author: svens
Date: Tue May 3 09:55:30 2011
New Revision: 6553
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6553
Log:
i82801gx: enable SPI prefetching
Signed-off-by: Sven Schnelle
Acked-by: Sven Schnelle
Added:
trunk/src/southbridge/intel/i82801gx/bootblock.c
Modified:
trunk/src/southbridge/intel/i82801gx/Kconfig
Modified: trunk/src/southbridge/intel/i82801gx/Kconfig
==
--- trunk/src/southbridge/intel/i82801gx/KconfigMon May 2 21:53:04
2011(r6552)
+++ trunk/src/southbridge/intel/i82801gx/KconfigTue May 3 09:55:30
2011(r6553)
@@ -38,5 +38,10 @@
int
default 1
+config BOOTBLOCK_SOUTHBRIDGE_INIT
+string
+ default "southbridge/intel/i82801gx/bootblock.c"
+ depends on SOUTHBRIDGE_INTEL_I82801GX
+
endif
Added: trunk/src/southbridge/intel/i82801gx/bootblock.c
==
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ trunk/src/southbridge/intel/i82801gx/bootblock.cTue May 3 09:55:30
2011(r6553)
@@ -0,0 +1,40 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2011 Sven Schnelle
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include
+#include
+
+static void enable_spi_prefetch(void)
+{
+u8 reg8;
+device_t dev;
+
+dev = PCI_DEV(0, 0x1f, 0);
+
+reg8 = pci_read_config8(dev, 0xdc);
+reg8 &= ~(3 << 2);
+reg8 |= (2 << 2); /* Prefetching and Caching Enabled */
+pci_write_config8(dev, 0xdc, reg8);
+}
+
+static void bootblock_southbridge_init(void)
+{
+enable_spi_prefetch();
+}
+
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
