[coreboot] cbfstool: Fill memory allocated in create_cbfs_file() with 0xff

[Peter Stuge]

See patch.


//Peter
cbfstool: Fill memory allocated in create_cbfs_file() with 0xff

This should improve programming speed a bit.

Signed-off-by: Peter Stuge pe...@stuge.se

Index: util/cbfstool/common.c
===
--- util/cbfstool/common.c  (revision 4973)
+++ util/cbfstool/common.c  (working copy)
@@ -279,6 +279,7 @@
   headersize);
exit(1);
}
+   memset(newdata, 0xff, *datasize + headersize);
struct cbfs_file *nextfile = (struct cbfs_file *)newdata;
strncpy(nextfile-magic, LARCHIVE, 8);
nextfile-len = htonl(*datasize);
-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot

Re: [coreboot] cbfstool: Fill memory allocated in create_cbfs_file() with 0xff

[Stefan Reinauer]

On 12/6/09 12:19 PM, Peter Stuge wrote:
 cbfstool: Fill memory allocated in create_cbfs_file() with 0xff

 This should improve programming speed a bit.

 Signed-off-by: Peter Stuge pe...@stuge.se
   
Unfortunately not a measurable improvement here with the Numonyx M25P32
and the Dediprog SF100, but I guess I need to figure out if it does
smart flashing at all.. (it did with some software release afaicr)

Anyways, good idea:
Acked-by: Stefan Reinauer ste...@coresystems.de

Stefan

-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot

Re: [coreboot] cbfstool: Fill memory allocated in create_cbfs_file() with 0xff

[Peter Stuge]

Stefan Reinauer wrote:
 Acked-by: Stefan Reinauer ste...@coresystems.de

r4975

-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot