Re: [coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
repository service wrote: +++ trunk/src/southbridge/intel/i82801gx/Kconfig Tue May 3 09:55:30 2011(r6553) @@ -38,5 +38,10 @@ int default 1 +config BOOTBLOCK_SOUTHBRIDGE_INIT +string + default southbridge/intel/i82801gx/bootblock.c + depends on SOUTHBRIDGE_INTEL_I82801GX + Why in Kconfig and not a Makefile variable? Oh and please always double-check the whitespace. (See string) //Peter -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
Peter Stuge pe...@stuge.se writes: repository service wrote: +++ trunk/src/southbridge/intel/i82801gx/Kconfig Tue May 3 09:55:30 2011(r6553) @@ -38,5 +38,10 @@ int default 1 +config BOOTBLOCK_SOUTHBRIDGE_INIT +string +default southbridge/intel/i82801gx/bootblock.c +depends on SOUTHBRIDGE_INTEL_I82801GX + Why in Kconfig and not a Makefile variable? That's how the current implementation wants it. Changing that is beyond the scope of that Patch. Sorry for the whitespace error. Sven. -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
On 03.05.2011, at 06:04, Peter Stuge pe...@stuge.se wrote: repository service wrote: +++ trunk/src/southbridge/intel/i82801gx/KconfigTue May 3 09:55:30 2011 (r6553) @@ -38,5 +38,10 @@ int default 1 +config BOOTBLOCK_SOUTHBRIDGE_INIT +string +default southbridge/intel/i82801gx/bootblock.c +depends on SOUTHBRIDGE_INTEL_I82801GX + Why in Kconfig and not a Makefile variable? Oh and please always double-check the whitespace. (See string) //Peter I agree this belongs in the Makefiles.. Not sure why we chose to put it here but it might have required another makefile pass otherwise -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
Am 03.05.2011 18:10, schrieb Stefan Reinauer: I agree this belongs in the Makefiles.. Not sure why we chose to put it here but it might have required another makefile pass otherwise Back then the build system was a bit limited, so this was more feasible. We also need to push data from build system variables into romcc (ie. -DA=B flags) for bootblock. Not impossible, but not as automatic as it currently works. Patrick -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
On 03.05.2011, at 11:01, Patrick Georgi patr...@georgi-clan.de wrote: Am 03.05.2011 18:10, schrieb Stefan Reinauer: I agree this belongs in the Makefiles.. Not sure why we chose to put it here but it might have required another makefile pass otherwise Back then the build system was a bit limited, so this was more feasible. We also need to push data from build system variables into romcc (ie. -DA=B flags) for bootblock. Not impossible, but not as automatic as it currently works. Can't we just call the bootblock compilation with -include path/to/component/bootblock.c ? Patrick -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [commit] r6553 - trunk/src/southbridge/intel/i82801gx
Am 03.05.2011 20:11, schrieb Stefan Reinauer: On 03.05.2011, at 11:01, Patrick Georgi patr...@georgi-clan.de wrote: We also need to push data from build system variables into romcc (ie. -DA=B flags) for bootblock. Not impossible, but not as automatic as it currently works. Can't we just call the bootblock compilation with -include path/to/component/bootblock.c ? Feasible, with some additional plumbing Patrick -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
