Re: [cross-project-issues-dev] Eclipse Mars 1 RC4 issue with Buildship / workspace prompt

[Mickael Istria]

On 09/23/2015 08:43 AM, Mickael Istria wrote:

On 09/23/2015 08:35 AM, Etienne Studer wrote:

Dave Williams gave directions on how to proceed with this problem:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=478054

In short, there will be no respin of Mars 1.
I've read David's comments there, and I fully disagree with it (for 
the reasons mentioned in previous mail). Isn't it something the 
Architecture Concil should decide?


Also, many extenders directly rely on the Simrel repo content to resolve 
their dependencies. So 3rd party projects extending or shipping 
buildship and referencing only Simrel repo (and not BuildShip one) will 
suffer from this issue and will have to fix it locally.
This issue introduce a non negligeable cost for all users, extenders and 
embedders of BuildShip who consume SimRel repo.

--
Mickael Istria
Eclipse developer at JBoss, by Red Hat 
My blog  - My Tweets 

___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

Re: [cross-project-issues-dev] Eclipse Mars 1 RC4 issue with Buildship / workspace prompt

[Mickael Istria]

On 09/23/2015 08:35 AM, Etienne Studer wrote:

Dave Williams gave directions on how to proceed with this problem:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=478054

In short, there will be no respin of Mars 1.
I've read David's comments there, and I fully disagree with it (for the 
reasons mentioned in previous mail). Isn't it something the Architecture 
Concil should decide?

--
Mickael Istria
Eclipse developer at JBoss, by Red Hat 
My blog  - My Tweets 

___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

Re: [cross-project-issues-dev] Eclipse Mars 1 RC4 issue with Buildship / workspace prompt

[Etienne Studer]

Hi

Dave Williams gave directions on how to proceed with this problem:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=478054

In short, there will be no respin of Mars 1.

Buildship 1.0.5 is available in the marketplace and contains the fix for this 
issue, incl. the contribution from Thomas.

Thanks for everyone’s input and sorry for the disturbance this issue created.

Regards, Etienne



On 22.09.2015, at 19:07, Etienne Studer  wrote:

> Hi
> 
> In our Gradle forum, a user recently reported a problem with not seeing the 
> workspace prompt when starting Eclipse and suspected that it is related to 
> Buildship. We created a BugZilla issue for this. After deeper investigations, 
> Simon Scholz from Vogella GmbH eventually found the problem and a fix:
> 
> When launching a Gradle build with Buildship 1.0.3, an extension point is 
> used to start the Buildship UI bundle. The code in Buildship which is 
> responsible for starting the Buildship UI bundle is called even when the UI 
> bundle is already active. This causes the 
> /configuration/org.eclipse.osgi/framework.info.{x} file to change into an 
> unstable state, and as a consequence the workspace prompt is not shown 
> anymore when starting Eclipse. The plugin activation code has been in 
> Buildship for a very long time but until very recently, nobody had ever 
> experienced this problem.
> 
> Buildship 1.0.4, built today, contains a patch for this issue by only 
> starting the UI bundle programmatically if the bundle is not already in state 
> “ACTIVE". This avoids the corruption of 
> /configuration/org.eclipse.osgi/framework.info.{x} and thus the workspace 
> prompt is always properly shown when starting Eclipse.
> 
> It seems like there is an underlying bug in the 
> org.osgi.framework.Bundle.start() method that causes the 
> /configuration/org.eclipse.osgi/framework.info.{x} to become corrupt when 
> start() is called and the bundle is already "ACTIVE". Unfortunately, we were 
> not able to read the /configuration/org.eclipse.osgi/framework.info.{x} file 
> and thus we were not able to confirm this theory, nor could we figure out 
> what was actually changed with tools like kdiff3.
> 
> How should we proceed from here?
> 
> Kind regards, Etienne
> 

___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

Re: [cross-project-issues-dev] Eclipse Mars 1 RC4 issue with Buildship / workspace prompt

[Etienne Studer]

Thanks, Thomas. I have applied your improvement to our fix. It is in Buildship 
1.0.5, released just a few minutes ago.

Regards, Etienne



On 22.09.2015, at 19:56, Thomas Watson  wrote:

> I think the fix in https://bugs.eclipse.org/bugs/show_bug.cgi?id=478054is 
> incorrect.  I added a comment to the defect with the details.
> 
> Tom
> 
> 
> 
> 
> 
> From:Etienne Studer 
> To:Cross project issues 
> Date:09/22/2015 12:08 PM
> Subject:[cross-project-issues-dev] Eclipse Mars 1 RC4 issue with 
> Buildship/ workspace prompt
> Sent by:cross-project-issues-dev-boun...@eclipse.org
> 
> 
> 
> Hi
> 
> In our Gradle forum, a user recently reported a problem with not seeing the 
> workspace prompt when starting Eclipse and suspected that it is related to 
> Buildship. We created a BugZilla issue for this. After deeper investigations, 
> Simon Scholz from Vogella GmbH eventually found the problem and a fix:
> 
> When launching a Gradle build with Buildship 1.0.3, an extension point is 
> used to start the Buildship UI bundle. The code in Buildship which is 
> responsible for starting the Buildship UI bundle is called even when the UI 
> bundle is already active. This causes the 
> /configuration/org.eclipse.osgi/framework.info.{x} file to change into an 
> unstable state, and as a consequence the workspace prompt is not shown 
> anymore when starting Eclipse. The plugin activation code has been in 
> Buildship for a very long time but until very recently, nobody had ever 
> experienced this problem.
> 
> Buildship 1.0.4, built today, contains a patch for this issue by only 
> starting the UI bundle programmatically if the bundle is not already in state 
> “ACTIVE". This avoids the corruption of 
> /configuration/org.eclipse.osgi/framework.info.{x} and thus the workspace 
> prompt is always properly shown when starting Eclipse.
> 
> It seems like there is an underlying bug in the 
> org.osgi.framework.Bundle.start() method that causes the 
> /configuration/org.eclipse.osgi/framework.info.{x} to become corrupt when 
> start() is called and the bundle is already "ACTIVE". Unfortunately, we were 
> not able to read the /configuration/org.eclipse.osgi/framework.info.{x} file 
> and thus we were not able to confirm this theory, nor could we figure out 
> what was actually changed with tools like kdiff3.
> 
> How should we proceed from here?
> 
> Kind regards, Etienne
> ___
> cross-project-issues-dev mailing list
> cross-project-issues-dev@eclipse.org
> To change your delivery options, retrieve your password, or unsubscribe from 
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
> 
> ___
> cross-project-issues-dev mailing list
> cross-project-issues-dev@eclipse.org
> To change your delivery options, retrieve your password, or unsubscribe from 
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

Re: [cross-project-issues-dev] Eclipse Mars 1 RC4 issue with Buildship / workspace prompt

[Simon Scholz]

Thanks Thomas, your suggested flag has been added now.

On 22.09.2015 19:56, Thomas Watson wrote:
I think the fix in 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=478054is incorrect.  I 
added a comment to the defect with the details.


Tom





From: Etienne Studer 
To: Cross project issues 
Date: 09/22/2015 12:08 PM
Subject: [cross-project-issues-dev] Eclipse Mars 1 RC4 issue with 
Buildship/ workspace prompt

Sent by: cross-project-issues-dev-boun...@eclipse.org




Hi

In our _Gradle forum_ 
, 
a user recently reported a problem with not seeing the workspace 
prompt when starting Eclipse and suspected that it is related to 
Buildship. We created a _BugZilla issue_ 
for this. After 
deeper investigations, Simon Scholz from Vogella GmbH eventually found 
the problem and a fix:


When launching a Gradle build with Buildship 1.0.3, an extension point 
is used to start the Buildship UI bundle. The code in Buildship which 
is responsible for starting the Buildship UI bundle is called even 
when the UI bundle is already active. This causes the 
/configuration/org.eclipse.osgi/framework.info.{x} file to change into 
an unstable state, and as a consequence the workspace prompt is not 
shown anymore when starting Eclipse. The plugin activation code has 
been in Buildship for a very long time but until very recently, nobody 
had ever experienced this problem.

_
__Buildship 1.0.4_ 
, 
built today, contains a patch for this issue by only starting the UI 
bundle programmatically if the bundle is not already in state 
“ACTIVE". This avoids the corruption of 
/configuration/org.eclipse.osgi/framework.info.{x} and thus the 
workspace prompt is always properly shown when starting Eclipse.


It seems like there is an underlying bug in the 
org.osgi.framework.Bundle.start() method that causes the 
/configuration/org.eclipse.osgi/framework.info.{x} to become corrupt 
when start() is called and the bundle is already "ACTIVE". 
Unfortunately, we were not able to read the 
/configuration/org.eclipse.osgi/framework.info.{x} file and thus we 
were not able to confirm this theory, nor could we figure out what was 
actually changed with tools like kdiff3.


How should we proceed from here?

Kind regards, Etienne
___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or 
unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev



___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev


--
Trainer, Consultant and Developer

vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Tel (040) 78804360, Fax (032) 221739404, Email: simon.sch...@vogella.com, Web: 
http://www.vogella.com

___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

Re: [cross-project-issues-dev] Eclipse Mars 1 RC4 issue with Buildship / workspace prompt

[Thomas Watson]

I think the fix in https://bugs.eclipse.org/bugs/show_bug.cgi?id=478054 is 
incorrect.  I added a comment to the defect with the details.

Tom





From:   Etienne Studer 
To: Cross project issues 
Date:   09/22/2015 12:08 PM
Subject:[cross-project-issues-dev] Eclipse Mars 1 RC4 issue with 
Buildship   / workspace prompt
Sent by:cross-project-issues-dev-boun...@eclipse.org



Hi

In our Gradle forum, a user recently reported a problem with not seeing 
the workspace prompt when starting Eclipse and suspected that it is 
related to Buildship. We created a BugZilla issue for this. After deeper 
investigations, Simon Scholz from Vogella GmbH eventually found the 
problem and a fix:

When launching a Gradle build with Buildship 1.0.3, an extension point is 
used to start the Buildship UI bundle. The code in Buildship which is 
responsible for starting the Buildship UI bundle is called even when the 
UI bundle is already active. This causes the 
/configuration/org.eclipse.osgi/framework.info.{x} file to change into an 
unstable state, and as a consequence the workspace prompt is not shown 
anymore when starting Eclipse. The plugin activation code has been in 
Buildship for a very long time but until very recently, nobody had ever 
experienced this problem.

Buildship 1.0.4, built today, contains a patch for this issue by only 
starting the UI bundle programmatically if the bundle is not already in 
state “ACTIVE". This avoids the corruption of 
/configuration/org.eclipse.osgi/framework.info.{x} and thus the workspace 
prompt is always properly shown when starting Eclipse.

It seems like there is an underlying bug in the 
org.osgi.framework.Bundle.start() method that causes the 
/configuration/org.eclipse.osgi/framework.info.{x} to become corrupt when 
start() is called and the bundle is already "ACTIVE". Unfortunately, we 
were not able to read the 
/configuration/org.eclipse.osgi/framework.info.{x} file and thus we were 
not able to confirm this theory, nor could we figure out what was actually 
changed with tools like kdiff3.

How should we proceed from here?

Kind regards, Etienne
___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe 
from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev


___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

Re: [cross-project-issues-dev] Eclipse Mars 1 RC4 issue with Buildship / workspace prompt

[Mickael Istria]

By the way, thanks to your user for finding this issue; and thank you 
for fixing it promptly and letting us know.

--
Mickael Istria
Eclipse developer at JBoss, by Red Hat 
My blog  - My Tweets 

___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

Re: [cross-project-issues-dev] Eclipse Mars 1 RC4 issue with Buildship / workspace prompt

[Mickael Istria]

On 09/22/2015 07:07 PM, Etienne Studer wrote:
In our Gradle forum 
, 
a user recently reported a problem with not seeing the workspace 
prompt when starting Eclipse and suspected that it is related to 
Buildship. We created a BugZilla issue 
 for this. After 
deeper investigations, Simon Scholz from Vogella GmbH eventually found 
the problem and a fix:

[...]
as a consequence the workspace prompt is not shown anymore when 
starting Eclipse. The plugin activation code has been in Buildship for 
a very long time but until very recently, nobody had ever experienced 
this problem.

[...]
Buildship 1.0.4 
, 
built today, contains a patch for this issue by only starting the 
UI bundle programmatically if the bundle is not already in state 
“ACTIVE". This avoids the corruption 
of /configuration/org.eclipse.osgi/framework.info.{x} and thus the 
workspace prompt is always properly shown when starting Eclipse.

[...]
How should we proceed from here?
Not prompting user for workspace is a critical bug. as many users deal 
with multiple workspaces.
IMO, Gradle support is the very new thing of this release, it's even one 
of the things that will most likely get advertised as part of Mars.1. So 
we can expect that the bug will have a high exposure and will hurt many 
users, giving an impression of "the only new thing in this release 
causes a blocker bug". This is not something the Eclipse Community and 
Eclipse IDE can afford.


There is no doubt this issue requires a respin of Mars.1.
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat 
My blog  - My Tweets 

___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

[cross-project-issues-dev] Eclipse Mars 1 RC4 issue with Buildship / workspace prompt

[Etienne Studer]

Hi

In our Gradle forum, a user recently reported a problem with not seeing the 
workspace prompt when starting Eclipse and suspected that it is related to 
Buildship. We created a BugZilla issue for this. After deeper investigations, 
Simon Scholz from Vogella GmbH eventually found the problem and a fix:

When launching a Gradle build with Buildship 1.0.3, an extension point is used 
to start the Buildship UI bundle. The code in Buildship which is responsible 
for starting the Buildship UI bundle is called even when the UI bundle is 
already active. This causes the 
/configuration/org.eclipse.osgi/framework.info.{x} file to change into an 
unstable state, and as a consequence the workspace prompt is not shown anymore 
when starting Eclipse. The plugin activation code has been in Buildship for a 
very long time but until very recently, nobody had ever experienced this 
problem.

Buildship 1.0.4, built today, contains a patch for this issue by only starting 
the UI bundle programmatically if the bundle is not already in state “ACTIVE". 
This avoids the corruption of 
/configuration/org.eclipse.osgi/framework.info.{x} and thus the workspace 
prompt is always properly shown when starting Eclipse.

It seems like there is an underlying bug in the 
org.osgi.framework.Bundle.start() method that causes the 
/configuration/org.eclipse.osgi/framework.info.{x} to become corrupt when 
start() is called and the bundle is already "ACTIVE". Unfortunately, we were 
not able to read the /configuration/org.eclipse.osgi/framework.info.{x} file 
and thus we were not able to confirm this theory, nor could we figure out what 
was actually changed with tools like kdiff3.

How should we proceed from here?

Kind regards, Etienne

___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

[cross-project-issues-dev] Does your project still receive patches through Bugzilla?

[Wim Jongman]

Hi,

We often still receive patches through Bugzilla. We then have to tell this
person (an occasional contributor) that we have switched to Gerrit.
Generally they are great about it but it would be best if we could avoid
this.

If you have the same experience or a solution, please chime in on this bug
[1].

[1] *Bug 478044*
 - Provide
a way to direct people to Gerrit

Cheers,

Wim
___
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev