Re: [cross-project-issues-dev] Xtext RC4
Hi Sven Doesn't it need PMC approvals before being resolved as fixed? From the yet to be superseded http://wiki.eclipse.org/Modeling_Project_Ramp_Down_Policy/Helios After RC3: Two additional Committers and at least 2 PMC members must review and vote +1 after reviewing the bug for appropriateness and risk. After reviewing the commit myself, I see quite a lot of new lines and control flow changes in core code, but the bug description reads as a UI inelegance rather than a killer. So IMHO not really appropriate for RC4. Regards Ed Willink On 12/06/2013 10:28, Sven Efftinge wrote: Here you are : https://bugs.eclipse.org/bugs/show_bug.cgi?id=410571 The respective hudson job is : https://hudson.eclipse.org/hudson/job/Xtext-nightly-HEAD/ On Jun 12, 2013, at 11:16 AM, Ed Willink e...@willink.me.uk wrote: Hi What's the fix, what's the Bugzilla, what's the commit? Where's the build? dashboard shows no builds in the last 24 hours. Regards Ed Willink On 12/06/2013 10:00, Sven Efftinge wrote: Hi all, I just wanted to inform you that we are building an RC4a today (now). It contains an important bug fix, which won't affect any downstream projects, but is important for end users. Regards, Sven ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev - No virus found in this message. Checked by AVG - www.avg.com Version: 2013.0.3345 / Virus Database: 3199/6403 - Release Date: 06/11/13 ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev - No virus found in this message. Checked by AVG - www.avg.com Version: 2013.0.3345 / Virus Database: 3199/6403 - Release Date: 06/11/13 ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
Re: [cross-project-issues-dev] Xtext RC4
Ed, comments inline On Jun 12, 2013, at 11:47 AM, Ed Willink e...@willink.me.uk wrote: Doesn't it need PMC approvals before being resolved as fixed? No, we don't follow that policy anymore. From the yet to be superseded http://wiki.eclipse.org/Modeling_Project_Ramp_Down_Policy/Helios After RC3: Two additional Committers and at least 2 PMC members must review and vote +1 after reviewing the bug for appropriateness and risk. Two additional committers have reviewed the change. I don't see why votes from the PMC would help. After reviewing the commit myself, I see quite a lot of new lines and control flow changes in core code, but the bug description reads as a UI inelegance rather than a killer. So IMHO not really appropriate for RC4. It's an important missing compiler analysis. I don't think UI is mentioned at all. Regards, Sven___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
Re: [cross-project-issues-dev] Xtext RC4
Hi all, Xtext RC4a was contributed to the simrel aggregator. The changes should be available with the next simrel.kepler.runaggregator build. Best regards, Dennis. Am 12.06.2013 um 11:00 schrieb Sven Efftinge: Hi all, I just wanted to inform you that we are building an RC4a today (now). It contains an important bug fix, which won't affect any downstream projects, but is important for end users. Regards, Sven ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev Dennis Hübner Xtext Commiter / Build Engineer Mobile: +49 (0) 151 / 17 39 67 07 Telefon: +49 (0) 431 / 990 268 70 Fax: +49 (0) 431 / 990 268 72 itemis AG Niederlassung Kiel Am Germaniahafen 1 24143 Kiel http://www.itemis.de/ Rechtlicher Hinweis: Amtsgericht Dortmund, HRB 20621 Vorstand: Jens Wagener (Vors.), Wolfgang Neuhaus, Dr. Georg Pietrek, Jens Trompeter, Sebastian Neus Aufsichtsrat: Dr. Burkhard Igel (Vors.), Stephan Grollmann, Michael Neuhaus ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
Re: [cross-project-issues-dev] Xtext RC4
FYI, I trust that project leads generally know what's best for their projects and for their downstream users, so I see no general need to police or review their decisions. Regards, Ed On 12/06/2013 12:42 PM, Sven Efftinge wrote: Ed, comments inline On Jun 12, 2013, at 11:47 AM, Ed Willink e...@willink.me.uk mailto:e...@willink.me.uk wrote: Doesn't it need PMC approvals before being resolved as fixed? No, we don't follow that policy anymore. From the yet to be superseded http://wiki.eclipse.org/Modeling_Project_Ramp_Down_Policy/Helios * After RC3 http://wiki.eclipse.org/Helios#Milestones_and_Release_Candidates: Two additional Committers and at least 2 PMC members must review and vote +1 after reviewing the bug for appropriateness and risk. Two additional committers have reviewed the change. I don't see why votes from the PMC would help. After reviewing the commit myself, I see quite a lot of new lines and control flow changes in core code, but the bug description reads as a UI inelegance rather than a killer. So IMHO not really appropriate for RC4. It's an important missing compiler analysis. I don't think UI is mentioned at all. Regards, Sven ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
